Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text labels for arbitrary numbers are invisible on macOS Mojave #22

Open
1l0 opened this issue Jun 3, 2019 · 5 comments
Open

Text labels for arbitrary numbers are invisible on macOS Mojave #22

1l0 opened this issue Jun 3, 2019 · 5 comments

Comments

@1l0
Copy link

1l0 commented Jun 3, 2019

It can be selected to see what number is but normally white text on white background on any themes.
Screen Shot 2019-06-03 at 12 50 13

@ahihi
Copy link

ahihi commented Mar 13, 2020

it seems this is a more general issue with macOS's dark mode being incompletely supported, resulting also in black text on a dark grey background etc.

i worked around this by adding NSRequiresAquaSystemAppearance = YES to the app's Info.plist, which enforces the light mode.

@DocSunset
Copy link

I've noticed that text is unreadable on my Arch Linux installation as well, presumably due to similar incomplete support for the dark theme set in my GUI toolkit.

@sletz
Copy link
Member

sletz commented Jun 22, 2022

Are you able to compile yourself: https://github.com/grame-cncm/faustlive and https://github.com/grame-cncm/faustlive/tree/master/Build and possibly hack the code to fix it?

@DocSunset
Copy link

I had a bit of trouble compiling because I forgot to git submodule update --init --recursive, but I managed it in the end. After a bit of poking around, I noticed that the default stylesheets are overridden in a number of places with calls to setStyleSheet. Considering at least one text label was overridden to have color: black, I thought this might be related to the problem, so I commented out all of the stylesheet overrides. This significantly improved the situation, enough so that I'm willing to state with certainty that these stylesheet overrides are the problem.

I leave it to you lovely maintainers to decide how best to proceed. Personally I don't mind the default styles.

@sletz
Copy link
Member

sletz commented Jun 22, 2022

Can you prepare a pull request with your changes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants