Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/v1/logs returns HTTP status 204 when it should return 200 #15761

Open
codefromthecrypt opened this issue Jan 15, 2025 · 0 comments · May be fixed by #15801
Open

/v1/logs returns HTTP status 204 when it should return 200 #15761

codefromthecrypt opened this issue Jan 15, 2025 · 0 comments · May be fixed by #15801
Labels
OTEL/OLTP type/bug Somehing is not working as expected

Comments

@codefromthecrypt
Copy link

Describe the bug

Currently, the /otlp/v1/logs endpoint returns HTTP 204, not HTTP 200 on success.

To Reproduce

https://github.com/grafana/loki/blob/main/pkg/distributor/http.go#L76C22-L76C37

Expected behavior

The spec says to return 200, and folks have run into issues resulting in a change to opentelemetry-python. If this can switch back, then folks don't have to go around changing every language to prevent validation errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OTEL/OLTP type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change pushHandler to return 200 not 204 sysadmin1139/loki
3 participants
@codefromthecrypt @chaudum @JStickler