Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

First sidebar appears over the top of the content area #149

Closed
rooby opened this issue Jan 25, 2016 · 10 comments
Closed

First sidebar appears over the top of the content area #149

rooby opened this issue Jan 25, 2016 · 10 comments

Comments

@rooby
Copy link

rooby commented Jan 25, 2016

When I assign blocks to the first sidebar the sidebar appears over the top of the content area, breaking the layout.

I am currently using govcms 7.x-2.0-beta8 with a sub-theme of govcms_zen that has not had any CSS changes since setting up the site.

This is what it looks like with a block in the second sidebar. Looks normal.
govcms-contact_second_sidebar

This is what it looks like with a block in the first sidebar when logged out:
govcms-contact_first_sidebar_anon

This is what it looks like with a block in the first sidebar when logged in as user 1:
govcms-contact_first_sidebar

@aleayr
Copy link
Contributor

aleayr commented Jan 25, 2016

Thanks for letting us know @rooby, I'll take a look shortly and try to reproduce as well.

@aleayr
Copy link
Contributor

aleayr commented Jan 25, 2016

@rooby, Can I understand how you did this? I've tried to reproduce, setup the same version of govCMS, and activated the govcms_zen theme, but I can't find a reference to a 'first sidebar' region by default in the theme.

I imagine I'm missing something that you've enabled or similar, so it would be helpful to know what I've missed so I can confirm this issue for you.

@rooby
Copy link
Author

rooby commented Jan 27, 2016

@aleayr

The theme I was referring to actually a sub-theme of the the govcms_zen theme. So the GOVCMS_STARTERKIT theme, with the name changed but with no other modifications.

Then assign any block to first sidebar.

I have just done another fresh install and the default theme after install is govCMS (Barton) and has the same problem if I put a block in the first sidebar.

As a side note, it seems like a bug that govcms has no sidebar_first region since both zen, STARTERKIT and GOVCMS_STARTERKIT all have that region.

@teamglenny
Copy link

Is it in all browsers, or only one browser (and if so which one), @rooby ?

@rooby
Copy link
Author

rooby commented Jan 28, 2016

I have tested in FireFox 43 & 44, Chrome 47 & 48 and IE 11 and it happens in all of them.

I've tried 2 separate installs of GovCMS and it happens on both.

@fiasco
Copy link
Contributor

fiasco commented May 18, 2016

Is this still a bug in 2.0? If so, please file a pull request for us to review. Thanks!

@rooby
Copy link
Author

rooby commented May 18, 2016

Yes it is still a problem.

To reproduce:

  1. Install default installation of GovCMS 2.0 (I included the example content).
  2. Go to the block admin page and move all blocks in the second sidebar to the first sidebar.
  3. Go to any page that has a sidebar (eg. publications or contact).

Unfortunately I don't have much time for front end work at the moment so realistically I won't be able to work on a pull request any time soon.

@pandaskii
Copy link
Contributor

thanks @rooby I can reproduce the same issue and a fix is in PR queue now

@fiasco
Copy link
Contributor

fiasco commented Aug 3, 2016

@rooby does that PR resolve the issue for you?

@fiasco fiasco added this to the 7.x-2.6 milestone Aug 3, 2016
@fiasco fiasco modified the milestones: 7.x-2.6, 7.x-2.7, 7.x-2.8 Aug 17, 2016
@fiasco fiasco modified the milestones: 7.x-2.8, 7.x-2.9, 7.x-2.10 Aug 25, 2016
@fiasco fiasco removed this from the 7.x-2.9 milestone Aug 25, 2016
@aleayr aleayr changed the title First sidebar appears over the top of the content area First sidebar appears over the top of the content area Aug 29, 2016
@aleayr aleayr closed this as completed Aug 29, 2016
@govhosting govhosting modified the milestones: 7.x-2.10, 7.x-2.9 Sep 28, 2016
@rooby
Copy link
Author

rooby commented Mar 13, 2018

@aleayr do you know why this issue was closed? It wasn't fixed.

Since I can't reopen issues I have created a follow up #660.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants