-
Notifications
You must be signed in to change notification settings - Fork 74
First sidebar appears over the top of the content area #149
Comments
Thanks for letting us know @rooby, I'll take a look shortly and try to reproduce as well. |
@rooby, Can I understand how you did this? I've tried to reproduce, setup the same version of govCMS, and activated the govcms_zen theme, but I can't find a reference to a 'first sidebar' region by default in the theme. I imagine I'm missing something that you've enabled or similar, so it would be helpful to know what I've missed so I can confirm this issue for you. |
The theme I was referring to actually a sub-theme of the the govcms_zen theme. So the GOVCMS_STARTERKIT theme, with the name changed but with no other modifications. Then assign any block to first sidebar. I have just done another fresh install and the default theme after install is govCMS (Barton) and has the same problem if I put a block in the first sidebar. As a side note, it seems like a bug that govcms has no sidebar_first region since both zen, STARTERKIT and GOVCMS_STARTERKIT all have that region. |
Is it in all browsers, or only one browser (and if so which one), @rooby ? |
I have tested in FireFox 43 & 44, Chrome 47 & 48 and IE 11 and it happens in all of them. I've tried 2 separate installs of GovCMS and it happens on both. |
Is this still a bug in 2.0? If so, please file a pull request for us to review. Thanks! |
Yes it is still a problem. To reproduce:
Unfortunately I don't have much time for front end work at the moment so realistically I won't be able to work on a pull request any time soon. |
thanks @rooby I can reproduce the same issue and a fix is in PR queue now |
@rooby does that PR resolve the issue for you? |
When I assign blocks to the first sidebar the sidebar appears over the top of the content area, breaking the layout.
I am currently using govcms 7.x-2.0-beta8 with a sub-theme of govcms_zen that has not had any CSS changes since setting up the site.
This is what it looks like with a block in the second sidebar. Looks normal.
This is what it looks like with a block in the first sidebar when logged out:
This is what it looks like with a block in the first sidebar when logged in as user 1:
The text was updated successfully, but these errors were encountered: