Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test_select_fd uses a lot of open files #1095

Open
fliiiix opened this issue Jan 21, 2025 · 0 comments
Open

New test_select_fd uses a lot of open files #1095

fliiiix opened this issue Jan 21, 2025 · 0 comments

Comments

@fliiiix
Copy link

fliiiix commented Jan 21, 2025

I stumbled over this new test from here: 3d1b888

test_inotify_c.py::test_select_fd

   > =========================== short test summary info ============================
   > FAILED tests/test_inotify_c.py::test_select_fd - OSError: [Errno 24] Too many open files: '/build/pytest-of-nixbld/pytest-0/test_select_fd0/new_file'
   > =========== 1 failed, 162 passed, 3 skipped, 3 deselected in 54.20s ============

Which will fails if the ulimit is too low. I naively doubled them from the default 1024 to the 2048 which is still to low for this test.
It would be kinda cool if this test could either fail with a more descriptive error message if the ulimit prevents this test from running successful but ideally i guess it would be even better if that could be tested without exhausting this many open files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants