Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Remove all Abseil dependencies #53

Open
kuhar opened this issue Sep 30, 2021 · 3 comments
Open

Remove all Abseil dependencies #53

kuhar opened this issue Sep 30, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@kuhar
Copy link
Contributor

kuhar commented Sep 30, 2021

We cannot use Abseil in dynamically loaded and dynamically unloaded libraries:
https://abseil.io/about/compatibility#what-users-must-and-must-not-do

Dynamic unloading of performance layers causes crashes because of Abseil code.

@kuhar kuhar added the bug Something isn't working label Sep 30, 2021
@Forchapeatl
Copy link

Hello @kuhar ,please are we to remove these lines of code ?

[submodule "external/abseil-cpp"]
path = third_party/abseil-cpp
url = https://github.com/abseil/abseil-cpp.git

# Abseil requires PIC.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")

add_subdirectory(abseil-cpp)

@kuhar
Copy link
Contributor Author

kuhar commented Nov 3, 2022

Yes, but we also need to remove any code that uses the abeil libraries and replace it with some combination of the c++ standard library, new hand-rolled counterparts, or possibly some alternative third-party library. The existing abseil code is easy to spot because it starts with absl:: and ABSL_.

@Forchapeatl
Copy link

Forchapeatl commented Nov 3, 2022

Thank you @kuhar

and replace it with some combination of the c++ standard library, new hand-rolled counterparts, or possibly some alternative third-party library.

Please do we have a replacement library , should I comment out the abseil code or do i just remove the abseil related code ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants