Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustsec reported date is being used as published date #2843

Closed
jayvdb opened this issue Nov 10, 2024 · 3 comments
Closed

rustsec reported date is being used as published date #2843

jayvdb opened this issue Nov 10, 2024 · 3 comments
Labels
stale The issue or PR is stale and pending automated closure

Comments

@jayvdb
Copy link

jayvdb commented Nov 10, 2024

Describe the bug
The RUSTSEC reported date is not the published date - the "issued" field is a closer concept.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to https://rustsec.org/advisories/RUSTSEC-2024-0388
  2. See it says "Issued: November 10, 2024" which is when derivative is unmaintained rustsec/advisory-db#1987 / Assigned RUSTSEC-2024-0388 to derivative rustsec/advisory-db#2119 occurred
  3. Click on JSON (OSV)
  4. See it includes "published":"2024-06-26T12:00:00Z" , which is when derivative is unmaintained rustsec/advisory-db#1987 was first created.

Expected behaviour
I believe the published field in osv.dev should be the issued date from RUSTSEC

Screenshots

Additional context

@andrewpollock
Copy link
Contributor

Hi,

Using RUSTSEC-2024-0388 as the full worked example...

I believe the published field in osv.dev should be the issued date from RUSTSEC

I'm inclined to agree, however this is incumbent on RUST Advisory Database to being publishing their records this way.

Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jan 10, 2025
@oliverchang
Copy link
Collaborator

Closing since the discussion is tracked in rustsec/advisory-db#2130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue or PR is stale and pending automated closure
Projects
None yet
Development

No branches or pull requests

3 participants