Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log extra fields not propagating #4200

Open
vitorguidi opened this issue Aug 21, 2024 · 6 comments
Open

Log extra fields not propagating #4200

vitorguidi opened this issue Aug 21, 2024 · 6 comments

Comments

@vitorguidi
Copy link
Collaborator

Extra log fields are not showing up in gcp, ie, docker_image

This issue is meant to map out all missing fields and make sure they show up

@oliverchang
Copy link
Collaborator

I think this is likely due to #3422. These structured logs are only well supported if we use google-cloud-logging. We should hopefully be unblocked there now that the Python upgrade is complete?

@vitorguidi
Copy link
Collaborator Author

Yes, we are unblocked. We run logging 3.6 now (ref)
I suggested this on the monitoring project

@oliverchang
Copy link
Collaborator

Yes, we are unblocked. We run logging 3.6 now (ref) I suggested this on the monitoring project

Awesome, let's see if we can revive #3422 then

@karinacayres
Copy link

@oliverchang does the #3422 requires either delete the fluentd and also, adding the google.cloud.logging for bot logging?

@oliverchang
Copy link
Collaborator

@oliverchang does the #3422 requires either delete the fluentd and also, adding the google.cloud.logging for bot logging?

Yes both are needed for #3422. #3422 should unblock this issue.

Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants