This is an example article
@@ -186,12 +176,12 @@ func TestProcessBookmark(t *testing.T) { Bookmark: bookmark, Content: content, ContentType: "text/html", - DataDir: "/tmp", + DataDir: tmpDir, KeepTitle: true, KeepExcerpt: true, } expected, _, _ := core.ProcessBookmark(deps, request) - + assert.True(t, deps.Domains.Storage.FileExists(fp.Join("thumb", "1"))) if expected.ID != bookmark.ID { t.Errorf("Unexpected ID: got %v, want %v", expected.ID, bookmark.ID) } @@ -206,6 +196,7 @@ func TestProcessBookmark(t *testing.T) { } }) t.Run("ProcessRequest sucssesful with empty title ", func(t *testing.T) { + tmpDir := t.TempDir() bookmark := model.BookmarkDTO{ ID: 1, URL: "https://example.com", @@ -219,7 +210,7 @@ func TestProcessBookmark(t *testing.T) { Bookmark: bookmark, Content: content, ContentType: "text/html", - DataDir: "/tmp", + DataDir: tmpDir, KeepTitle: true, KeepExcerpt: true, } @@ -239,6 +230,7 @@ func TestProcessBookmark(t *testing.T) { } }) t.Run("ProcessRequest sucssesful with empty Excerpt", func(t *testing.T) { + tmpDir := t.TempDir() bookmark := model.BookmarkDTO{ ID: 1, URL: "https://example.com", @@ -252,7 +244,7 @@ func TestProcessBookmark(t *testing.T) { Bookmark: bookmark, Content: content, ContentType: "text/html", - DataDir: "/tmp", + DataDir: tmpDir, KeepTitle: true, KeepExcerpt: false, } @@ -272,6 +264,7 @@ func TestProcessBookmark(t *testing.T) { } }) t.Run("Specific case", func(t *testing.T) { + tmpDir := t.TempDir() t.Run("ProcessRequest with ID zero", func(t *testing.T) { bookmark := model.BookmarkDTO{ @@ -287,7 +280,7 @@ func TestProcessBookmark(t *testing.T) { Bookmark: bookmark, Content: content, ContentType: "text/html", - DataDir: "/tmp", + DataDir: tmpDir, KeepTitle: true, KeepExcerpt: true, } @@ -298,7 +291,7 @@ func TestProcessBookmark(t *testing.T) { }) t.Run("ProcessRequest that content type not zero", func(t *testing.T) { - + tmpDir := t.TempDir() bookmark := model.BookmarkDTO{ ID: 1, URL: "https://example.com", @@ -312,7 +305,7 @@ func TestProcessBookmark(t *testing.T) { Bookmark: bookmark, Content: content, ContentType: "application/pdf", - DataDir: "/tmp", + DataDir: tmpDir, KeepTitle: true, KeepExcerpt: true, } diff --git a/internal/database/database_test.go b/internal/database/database_test.go index 01f8a9d91..cb00b5402 100644 --- a/internal/database/database_test.go +++ b/internal/database/database_test.go @@ -6,10 +6,11 @@ import ( "github.com/go-shiori/shiori/internal/model" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) type databaseTestCase func(t *testing.T, db DB) -type testDatabaseFactory func(ctx context.Context) (DB, error) +type testDatabaseFactory func(t *testing.T, ctx context.Context) (DB, error) func testDatabase(t *testing.T, dbFactory testDatabaseFactory) { tests := map[string]databaseTestCase{ @@ -30,12 +31,17 @@ func testDatabase(t *testing.T, dbFactory testDatabaseFactory) { // Tags "testCreateTag": testCreateTag, "testCreateTags": testCreateTags, + // Accounts + "testSaveAccount": testSaveAccount, + "testSaveAccountSetting": testSaveAccountSettings, + "testGetAccount": testGetAccount, + "testGetAccounts": testGetAccounts, } for testName, testCase := range tests { t.Run(testName, func(tInner *testing.T) { ctx := context.TODO() - db, err := dbFactory(ctx) + db, err := dbFactory(t, ctx) assert.NoError(tInner, err, "Error recreating database") testCase(tInner, db) }) @@ -323,3 +329,98 @@ func testCreateTags(t *testing.T, db DB) { err := db.CreateTags(ctx, model.Tag{Name: "shiori"}, model.Tag{Name: "shiori2"}) assert.NoError(t, err, "Save tag must not fail") } + +func testSaveAccount(t *testing.T, db DB) { + ctx := context.TODO() + + t.Run("success", func(t *testing.T) { + acc := model.Account{ + Username: "testuser", + Config: model.UserConfig{}, + } + + err := db.SaveAccount(ctx, acc) + require.Nil(t, err) + }) +} + +func testSaveAccountSettings(t *testing.T, db DB) { + ctx := context.TODO() + + t.Run("success", func(t *testing.T) { + acc := model.Account{ + Username: "test", + Config: model.UserConfig{}, + } + + err := db.SaveAccountSettings(ctx, acc) + require.Nil(t, err) + }) +} + +func testGetAccount(t *testing.T, db DB) { + ctx := context.TODO() + + t.Run("success", func(t *testing.T) { + // Insert test accounts + testAccounts := []model.Account{ + {Username: "foo", Password: "bar", Owner: false}, + {Username: "hello", Password: "world", Owner: false}, + {Username: "foo_bar", Password: "foobar", Owner: true}, + } + for _, acc := range testAccounts { + err := db.SaveAccount(ctx, acc) + assert.Nil(t, err) + + // Successful case + account, exists, err := db.GetAccount(ctx, acc.Username) + assert.Nil(t, err) + assert.True(t, exists, "Expected account to exist") + assert.Equal(t, acc.Username, account.Username) + } + // Falid case + account, exists, err := db.GetAccount(ctx, "foobar") + assert.NotNil(t, err) + assert.False(t, exists, "Expected account to exist") + assert.Empty(t, account.Username) + }) +} + +func testGetAccounts(t *testing.T, db DB) { + ctx := context.TODO() + + t.Run("success", func(t *testing.T) { + // Insert test accounts + testAccounts := []model.Account{ + {Username: "foo", Password: "bar", Owner: false}, + {Username: "hello", Password: "world", Owner: false}, + {Username: "foo_bar", Password: "foobar", Owner: true}, + } + for _, acc := range testAccounts { + err := db.SaveAccount(ctx, acc) + assert.Nil(t, err) + } + + // Successful case + // without opt + accounts, err := db.GetAccounts(ctx, GetAccountsOptions{}) + assert.NoError(t, err) + assert.Equal(t, 3, len(accounts)) + // with owner + accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Owner: true}) + assert.NoError(t, err) + assert.Equal(t, 1, len(accounts)) + // with opt + accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "foo"}) + assert.NoError(t, err) + assert.Equal(t, 2, len(accounts)) + // with opt and owner + accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "hello", Owner: false}) + assert.NoError(t, err) + assert.Equal(t, 1, len(accounts)) + // with not result + accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "shiori"}) + assert.NoError(t, err) + assert.Equal(t, 0, len(accounts)) + }) +} diff --git a/internal/database/mysql_test.go b/internal/database/mysql_test.go index e591464c0..9ff2f2fe5 100644 --- a/internal/database/mysql_test.go +++ b/internal/database/mysql_test.go @@ -1,17 +1,17 @@ +//go:build !test_sqlite_only +// +build !test_sqlite_only + package database import ( "context" "log" "os" - "path/filepath" "testing" - "github.com/go-shiori/shiori/internal/model" "github.com/golang-migrate/migrate/v4" "github.com/jmoiron/sqlx" "github.com/pkg/errors" - "github.com/stretchr/testify/assert" ) func init() { @@ -21,7 +21,7 @@ func init() { } } -func mysqlTestDatabaseFactory(ctx context.Context) (DB, error) { +func mysqlTestDatabaseFactory(_ *testing.T, ctx context.Context) (DB, error) { connString := os.Getenv("SHIORI_TEST_MYSQL_URL") db, err := OpenMySQLDatabase(ctx, connString) if err != nil { @@ -61,117 +61,3 @@ func mysqlTestDatabaseFactory(ctx context.Context) (DB, error) { func TestMysqlsDatabase(t *testing.T) { testDatabase(t, mysqlTestDatabaseFactory) } - -func TestSaveAccountSettingsMySql(t *testing.T) { - ctx := context.TODO() - - db, err := mysqlTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Mock data - account := model.Account{ - Username: "testuser", - Config: model.UserConfig{}, - } - - // Successful case - err = db.SaveAccountSettings(ctx, account) - assert.NoError(t, err) - - // Initialize not correct database - ctx = context.TODO() - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err = factory(ctx) - assert.Nil(t, err) - account = model.Account{ - Username: "testuser", - Config: model.UserConfig{}, - } - err = db.SaveAccountSettings(ctx, account) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") -} - -func TestGetAccountsMySql(t *testing.T) { - ctx := context.TODO() - - db, err := mysqlTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Insert test accounts - testAccounts := []model.Account{ - {Username: "foo", Password: "bar", Owner: false}, - {Username: "hello", Password: "world", Owner: false}, - {Username: "foo_bar", Password: "foobar", Owner: true}, - } - for _, acc := range testAccounts { - err := db.SaveAccount(ctx, acc) - assert.Nil(t, err) - } - - // Successful case - // without opt - accounts, err := db.GetAccounts(ctx, GetAccountsOptions{}) - assert.NoError(t, err) - assert.Equal(t, 3, len(accounts)) - // with owner - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Owner: true}) - assert.NoError(t, err) - assert.Equal(t, 1, len(accounts)) - // with opt - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "foo"}) - assert.NoError(t, err) - assert.Equal(t, 2, len(accounts)) - // with opt and owner - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "hello", Owner: false}) - assert.NoError(t, err) - assert.Equal(t, 1, len(accounts)) - // with not result - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "shiori"}) - assert.NoError(t, err) - assert.Equal(t, 0, len(accounts)) - - // Initialize not correct database - ctx = context.TODO() - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err = factory(ctx) - assert.Nil(t, err) - // with invalid query - opts := GetAccountsOptions{Keyword: "foo", Owner: true} - _, err = db.GetAccounts(ctx, opts) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") -} - -func TestGetAccountMySql(t *testing.T) { - ctx := context.TODO() - - db, err := mysqlTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Insert test accounts - testAccounts := []model.Account{ - {Username: "foo", Password: "bar", Owner: false}, - {Username: "hello", Password: "world", Owner: false}, - {Username: "foo_bar", Password: "foobar", Owner: true}, - } - for _, acc := range testAccounts { - err := db.SaveAccount(ctx, acc) - assert.Nil(t, err) - - // Successful case - account, exists, err := db.GetAccount(ctx, acc.Username) - assert.Nil(t, err) - assert.True(t, exists, "Expected account to exist") - assert.Equal(t, acc.Username, account.Username) - } - // Falid case - account, exists, err := db.GetAccount(ctx, "foobar") - assert.NotNil(t, err) - assert.False(t, exists, "Expected account to exist") - assert.Empty(t, account.Username) -} diff --git a/internal/database/pg_test.go b/internal/database/pg_test.go index cabfe89b6..eb1620386 100644 --- a/internal/database/pg_test.go +++ b/internal/database/pg_test.go @@ -1,3 +1,6 @@ +//go:build !test_sqlite_only +// +build !test_sqlite_only + package database import ( @@ -5,12 +8,9 @@ import ( "errors" "log" "os" - "path/filepath" "testing" - "github.com/go-shiori/shiori/internal/model" "github.com/golang-migrate/migrate/v4" - "github.com/stretchr/testify/assert" ) func init() { @@ -20,7 +20,7 @@ func init() { } } -func postgresqlTestDatabaseFactory(ctx context.Context) (DB, error) { +func postgresqlTestDatabaseFactory(_ *testing.T, ctx context.Context) (DB, error) { db, err := OpenPGDatabase(ctx, os.Getenv("SHIORI_TEST_PG_URL")) if err != nil { return nil, err @@ -41,116 +41,3 @@ func postgresqlTestDatabaseFactory(ctx context.Context) (DB, error) { func TestPostgresDatabase(t *testing.T) { testDatabase(t, postgresqlTestDatabaseFactory) } - -func TestSaveAccountSettingsPg(t *testing.T) { - ctx := context.TODO() - - db, err := postgresqlTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Mock data - account := model.Account{ - Username: "testuser", - Config: model.UserConfig{}, - } - - // Successful case - err = db.SaveAccountSettings(ctx, account) - assert.NoError(t, err) - - // Initialize not correct database - ctx = context.TODO() - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err = factory(ctx) - assert.Nil(t, err) - account = model.Account{ - Username: "testuser", - Config: model.UserConfig{}, - } - err = db.SaveAccountSettings(ctx, account) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") -} -func TestGetAccountsPg(t *testing.T) { - ctx := context.TODO() - - db, err := postgresqlTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Insert test accounts - testAccounts := []model.Account{ - {Username: "foo", Password: "bar", Owner: false}, - {Username: "hello", Password: "world", Owner: false}, - {Username: "foo_bar", Password: "foobar", Owner: true}, - } - for _, acc := range testAccounts { - err := db.SaveAccount(ctx, acc) - assert.Nil(t, err) - } - - // Successful case - // without opt - accounts, err := db.GetAccounts(ctx, GetAccountsOptions{}) - assert.NoError(t, err) - assert.Equal(t, 3, len(accounts)) - // with owner - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Owner: true}) - assert.NoError(t, err) - assert.Equal(t, 1, len(accounts)) - // with opt - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "foo"}) - assert.NoError(t, err) - assert.Equal(t, 2, len(accounts)) - // with opt and owner - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "hello", Owner: false}) - assert.NoError(t, err) - assert.Equal(t, 1, len(accounts)) - // with not result - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "shiori"}) - assert.NoError(t, err) - assert.Equal(t, 0, len(accounts)) - - // Initialize not correct database - ctx = context.TODO() - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err = factory(ctx) - assert.Nil(t, err) - // with invalid query - opts := GetAccountsOptions{Keyword: "foo", Owner: true} - _, err = db.GetAccounts(ctx, opts) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") -} - -func TestGetAccountPg(t *testing.T) { - ctx := context.TODO() - - db, err := postgresqlTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Insert test accounts - testAccounts := []model.Account{ - {Username: "foo", Password: "bar", Owner: false}, - {Username: "hello", Password: "world", Owner: false}, - {Username: "foo_bar", Password: "foobar", Owner: true}, - } - for _, acc := range testAccounts { - err := db.SaveAccount(ctx, acc) - assert.Nil(t, err) - - // Successful case - account, exists, err := db.GetAccount(ctx, acc.Username) - assert.Nil(t, err) - assert.True(t, exists, "Expected account to exist") - assert.Equal(t, acc.Username, account.Username) - } - // Falid case - account, exists, err := db.GetAccount(ctx, "foobar") - assert.NotNil(t, err) - assert.False(t, exists, "Expected account to exist") - assert.Empty(t, account.Username) -} diff --git a/internal/database/sqlite_test.go b/internal/database/sqlite_test.go index 509df0e5c..264a05e44 100644 --- a/internal/database/sqlite_test.go +++ b/internal/database/sqlite_test.go @@ -10,18 +10,14 @@ import ( "github.com/golang-migrate/migrate/v4" "github.com/pkg/errors" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) -var sqliteDatabaseTestPath string +func sqliteTestDatabaseFactory(t *testing.T, ctx context.Context) (DB, error) { + tmpDir, err := os.MkdirTemp("", "") + require.NoError(t, err) -func init() { - sqliteDatabaseTestPath = filepath.Join(os.TempDir(), "shiori.db") -} - -func sqliteTestDatabaseFactory(ctx context.Context) (DB, error) { - os.Remove(sqliteDatabaseTestPath) - - db, err := OpenSQLiteDatabase(ctx, sqliteDatabaseTestPath) + db, err := OpenSQLiteDatabase(ctx, filepath.Join(tmpDir, "shiori.db")) if err != nil { return nil, err } @@ -47,7 +43,7 @@ func TestSqliteDatabase(t *testing.T) { func testSqliteGetBookmarksWithDash(t *testing.T) { ctx := context.TODO() - db, err := sqliteTestDatabaseFactory(ctx) + db, err := sqliteTestDatabaseFactory(t, ctx) assert.NoError(t, err) book := model.BookmarkDTO{ @@ -76,105 +72,3 @@ func testSqliteGetBookmarksWithDash(t *testing.T) { assert.Equal(t, savedBookmark.ID, results[0].ID, "bookmark should be the one saved") } -func TestSQLiteDatabase_SaveAccount(t *testing.T) { - - ctx := context.TODO() - - // Initialize not correct database - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err := factory(ctx) - assert.Nil(t, err) - - // Test falid database - acc := model.Account{} - err = db.SaveAccount(ctx, acc) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") - -} - -func TestSaveAccountSettings(t *testing.T) { - ctx := context.TODO() - - db, err := sqliteTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Mock data - account := model.Account{ - Username: "testuser", - Config: model.UserConfig{}, - } - - // Successful case - err = db.SaveAccountSettings(ctx, account) - assert.NoError(t, err) - - // Initialize not correct database - ctx = context.TODO() - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err = factory(ctx) - assert.Nil(t, err) - account = model.Account{ - Username: "testuser", - Config: model.UserConfig{}, - } - err = db.SaveAccountSettings(ctx, account) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") -} - -func TestGetAccounts(t *testing.T) { - ctx := context.TODO() - - db, err := sqliteTestDatabaseFactory(ctx) - assert.NoError(t, err) - - // Insert test accounts - testAccounts := []model.Account{ - {Username: "foo", Password: "bar", Owner: false}, - {Username: "hello", Password: "world", Owner: false}, - {Username: "foo_bar", Password: "foobar", Owner: true}, - } - for _, acc := range testAccounts { - err := db.SaveAccount(ctx, acc) - assert.Nil(t, err) - } - - // Successful case - // without opt - accounts, err := db.GetAccounts(ctx, GetAccountsOptions{}) - assert.NoError(t, err) - assert.Equal(t, 3, len(accounts)) - // with owner - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Owner: true}) - assert.NoError(t, err) - assert.Equal(t, 1, len(accounts)) - // with opt - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "foo"}) - assert.NoError(t, err) - assert.Equal(t, 2, len(accounts)) - // with opt and owner - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "hello", Owner: false}) - assert.NoError(t, err) - assert.Equal(t, 1, len(accounts)) - // with not result - accounts, err = db.GetAccounts(ctx, GetAccountsOptions{Keyword: "shiori"}) - assert.NoError(t, err) - assert.Equal(t, 0, len(accounts)) - - // Initialize not correct database - ctx = context.TODO() - factory := func(ctx context.Context) (DB, error) { - return OpenSQLiteDatabase(ctx, filepath.Join(os.TempDir(), "shiori_test.db")) - } - db, err = factory(ctx) - assert.Nil(t, err) - // with invalid query - opts := GetAccountsOptions{Keyword: "foo", Owner: true} - _, err = db.GetAccounts(ctx, opts) - assert.NotNil(t, err) - assert.Contains(t, err.Error(), "SQL logic error: no such table: account (1)") -} diff --git a/internal/http/routes/frontend.go b/internal/http/routes/frontend.go index 7504dc871..364a5d2a4 100644 --- a/internal/http/routes/frontend.go +++ b/internal/http/routes/frontend.go @@ -3,7 +3,7 @@ package routes import ( "embed" "net/http" - "path/filepath" + "path" "github.com/gin-contrib/static" "github.com/gin-gonic/gin" @@ -27,7 +27,7 @@ func (fs assetsFS) Exists(prefix string, path string) bool { } func (fs assetsFS) Open(name string) (http.File, error) { - f, err := fs.FileSystem.Open(filepath.Join("assets", name)) + f, err := fs.FileSystem.Open(path.Join("assets", name)) if err != nil { logrus.WithError(err).WithField("path", name).Error("requested frontend file not found") } diff --git a/internal/testutil/shiori.go b/internal/testutil/shiori.go index 86120658f..fd6272cba 100644 --- a/internal/testutil/shiori.go +++ b/internal/testutil/shiori.go @@ -21,18 +21,21 @@ func GetTestConfigurationAndDependencies(t *testing.T, ctx context.Context, logg tmp, err := os.CreateTemp("", "") require.NoError(t, err) + t.Cleanup(func() { + os.Remove(tmp.Name()) + }) cfg := config.ParseServerConfiguration(ctx, logger) cfg.Http.SecretKey = []byte("test") - tempDir, err := os.MkdirTemp("", "") + tmpDir, err := os.MkdirTemp("", "") require.NoError(t, err) db, err := database.OpenSQLiteDatabase(ctx, tmp.Name()) require.NoError(t, err) require.NoError(t, db.Migrate()) - cfg.Storage.DataDir = tempDir + cfg.Storage.DataDir = tmpDir deps := dependencies.NewDependencies(logger, db, cfg) deps.Database = db diff --git a/scripts/test.sh b/scripts/test.sh index 7d2b8bca4..1893616da 100644 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -1,13 +1,12 @@ #!/bin/bash # Check if gotestfmt is installed -GOTESTFMT=$(which gotestfmt) -if [[ -z "${GOTESTFMT}" ]]; then +if ! [ -x "$(command -v gotestfmt)" ]; then echo "gotestfmt not found. Using test standard output." fi # if gotestfmt is installed, run with it -if [[ -n "${GOTESTFMT}" ]]; then +if [ -x "$(command -v gotestfmt)" ]; then set -o pipefail go test ./... ${GO_TEST_FLAGS} -json | gotestfmt ${GOTESTFMT_FLAGS} else