Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hystrix pkg don't support fallback func #1227

Open
techroaming111 opened this issue Apr 26, 2022 · 3 comments
Open

hystrix pkg don't support fallback func #1227

techroaming111 opened this issue Apr 26, 2022 · 3 comments

Comments

@techroaming111
Copy link

What would you like?

I want to use hystrix as cb and want to set fallback func once execute failed
@peterbourgon
Copy link
Member

You can do this without explicit support in Go kit, can't you?

@techroaming111
Copy link
Author

techroaming111 commented Apr 26, 2022 •
edited
Loading

Yes, I can, but since our Go-Kit supports this function, we'd better support fallback in this function. Let me mention MR, is it ok for you?

@peterbourgon
Copy link
Member

Feel free to make a PR but consider it a method of explanation, as I don't yet understand why this is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbourgon @techroaming111