Cyclic dependency with filetests

[leohhhn]

Description

Cross-posting from #3166 (comment)

Affects #3166 & #3523

I found an issue in how packages are loaded during txtar, that creates cyclic dependencies, specifically related to filetests:

• in r/gov/dao/v2/prop1_filetest.gno, we import, say r/sys/validators
• r/sys/validators imports r/gov/dao/bridge
• r/gov/dao/bridge imports r/gov/dao/v2 package
• which, because of the r/gov/dao/v2/prop1_filetest.gno file, technically, even though filetests are seen as "outside" packages (ie not part of the one found in the same dir), imports r/sys/validators, creating a cyclic dependency error.

This simple txtar fails on master:

loadpkg gno.land/r/gov/dao/v2

gnoland start

Removing filetests in r/gov/dao/v2 makes the txtar above pass on master.

I could be wrong but I assume it's related to the fact that filetests are not properly ignored during package loading, at least during testing.

cc @gfanton @thehowl

[leohhhn]

Fixed in #3550