Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR label automation #3072

Closed
Kouteki opened this issue Nov 6, 2024 · 5 comments · Fixed by #3530
Closed

PR label automation #3072

Kouteki opened this issue Nov 6, 2024 · 5 comments · Fixed by #3530
Assignees
@aeddi

Comments

@Kouteki
Copy link
Contributor

Kouteki commented Nov 6, 2024 •
edited
Loading

Current state

Review team manually has to apply labels when they are reviewing PRs, which is wasteful labor, and sometimes does not represent the actual state.

Desired state

Labels are automatically applied by the github bot, and filtering by labels serves as the source of truth

Acceptance criteria

  • When a new PR is opened by someone NOT on the Tech-staff team AND the PR is not in draft, apply the review/triage-pending label
  • When a PR with review/triage-pending has been approved by anyone, remove review/triage-pending
  • When a PR with is moved from open to draft, remove the review/triage-pending label (split to Open to draft PR label automation #3093 )
@Kouteki Kouteki moved this from Triage to Backlog in 🧙‍♂️gno.land core team Nov 6, 2024
@Kouteki Kouteki mentioned this issue Nov 6, 2024
Merged
7 tasks
@Kouteki Kouteki changed the title Basic PR review bot automation PR label automation Nov 6, 2024
@thehowl thehowl mentioned this issue Nov 6, 2024
Open
2 tasks
@moul
Copy link
Member

moul commented Nov 6, 2024 •
edited
Loading

#3037, #1007, #1466, #2788

@aeddi
Copy link
Contributor

aeddi commented Nov 6, 2024

The current state of the bot should be able handle the two first points (related to labels). But I will need to implement the draft/ready for review detection.

Maybe we can first merge it, then add this feature afterward?

@thehowl
Copy link
Member

thehowl commented Nov 6, 2024

definitely ;)

@Kouteki
Copy link
Contributor Author

Kouteki commented Nov 8, 2024

Maybe we can first merge it, then add this feature afterward?

Yes please! Incremental progress is the way to go.

@Kouteki Kouteki mentioned this issue Nov 8, 2024
Closed
1 task
@Kouteki
Copy link
Contributor Author

Kouteki commented Nov 8, 2024 •
edited
Loading

I split the 3rd item into a separate issue
#3093

@thehowl thehowl mentioned this issue Jan 16, 2025
Merged
thehowl added a commit that referenced this issue Jan 21, 2025
@thehowl
feat(github-bot): support review team flows (#3530)
c74fb57 
Fixes #3072, Fixes #3093.

Should add support for the required workflows on the GitHub bot, for the
review team.

cc @Kouteki @jefft0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeddi aeddi

Labels
None yet
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(github-bot): support review team flows thehowl/gno
4 participants
@moul @thehowl @aeddi @Kouteki