Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving a token that is hidden makes it visible #24

Open
feltz916 opened this issue Oct 28, 2020 · 8 comments
Open

Moving a token that is hidden makes it visible #24

feltz916 opened this issue Oct 28, 2020 · 8 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@feltz916
Copy link

Pretty sure this started after 0.7.5 update.

Steps to repro:

  • Roll stealth on a npc token
  • See it disappear on player screen
  • move the npc token
  • see it appear on player screen
@gludington
Copy link
Owner

It appears on token move, the rendering goes through a different code path altogether until the next time the token doing the seeing is touched, which means this module does not touch it. Will need to figure out where that separate drawing pipeline is, and see if it can be inserted at all.

@gludington
Copy link
Owner

0.75 introduced a different code path for moving tokens, such that monkeypatching it for a module could be dangerously brittle. Filed an issue for discussion at https://gitlab.com/foundrynet/foundryvtt/-/issues/3974

@feltz916
Copy link
Author

feltz916 commented Nov 9, 2020

@gludington it looks like some support for this was put into 0.7.6 core, will that allow progress to be made?

@gludington
Copy link
Owner

Yes, it does, and I have been looking at it as time permits, though I may not be able to fully commit until the weekend. If you are interested/able to install from and test a pre-release manifest URL, I may be able to place a work in progress tomorrow after work.

@gludington gludington added bug Something isn't working good first issue Good for newcomers labels Nov 12, 2020
@Avitale34
Copy link

Still having this issue :( any chance of fix? I love using this module!

@OmnesPotens
Copy link

@gludington This seems to be happening with the "In Darkness" condition as well.

Foundry version: 0.7.9
5e Version: 1.2.0

@feltz916
Copy link
Author

any updates to this issue?

@ArdonDaros
Copy link

This problem is also manifest with PF1 system, running the latest stable versions of both Foundry (0.7.9) and PF1 system: The token is correctly hidden, but as soon as the affected token is moved, players are able to see it normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants