Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Components Going Off When Full-Screen Mode Enabled #740

Open
HaithamLeo opened this issue Jul 19, 2023 · 1 comment
Open

Popup Components Going Off When Full-Screen Mode Enabled #740

HaithamLeo opened this issue Jul 19, 2023 · 1 comment
Labels
package:core Requests related to the core package type:bug Something isn't working

Comments

@HaithamLeo
Copy link

HaithamLeo commented Jul 19, 2023

Description

Steps to Reproduce:

  1. I wrapped my data editor component inside Fullscreen component.
const Fullscreen = ({ full, children }: FullscreenProps): JSX.Element => {
  const element = document.querySelector('#full-screen')

  if (full) {
    // make the element go to full-screen mode
    element?.requestFullscreen?.()
  } else {
    document.exitFullscreen?.()
  }

  return (
    <div id="full-screen">
      <DataEditor/>
    </div>
  )
}
  1. Enable full-screen mode on the data grid.
  2. Observe that some of the popup components, such as the data grid header menu, go off the screen and become inaccessible.

Expected Behavior:
When enabling full-screen mode, all components, including popups and overlays, should remain visible and accessible within the full-screen view.

Actual Behavior:
Certain popup components, such as the data grid header menu, disappear or go off the screen when full-screen mode is enabled, making it difficult to interact with them.

Additional Information:
Upon further investigation, it appears that the popup components are located inside layers overlays and are not direct child components of the data editor. This might be causing the issue when entering full-screen mode.

Environment

  • Operating System: Linux
  • Browser: Google Chrome
@pzcfg
Copy link
Contributor

pzcfg commented Jul 28, 2023

It seems like this may need to be fixed in the layer library itself everweij/react-laag#92

@jassmith jassmith added the type:bug Something isn't working label Aug 18, 2023
@lukasmasuch lukasmasuch added the package:core Requests related to the core package label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:core Requests related to the core package type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants