Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nox is missing --inplace so HTML artefacts never change #460

Closed
paddyroddy opened this issue Nov 28, 2024 · 1 comment · Fixed by #461
Closed

nox is missing --inplace so HTML artefacts never change #460

paddyroddy opened this issue Nov 28, 2024 · 1 comment · Fixed by #461
Assignees
@Saransh-cpp
Labels
bug Something isn't working

Comments

@paddyroddy
Copy link
Member

This surprised me, so I had a look. I guess you used our noxfile ... where we forgot to add the --inplace flag to the jupyter execute so that the execution actually changes the notebooks! At the moment, the notebooks run, but their outputs aren't stored anywhere (and our examples' HTML artefacts therefore never change). That's on me, I should have picked up on it in #367.

Originally posted by @ntessore in #425 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saransh-cpp Saransh-cpp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-460: update notebooks inplace when running nox -s examples glass-dev/glass
2 participants
@paddyroddy @Saransh-cpp