You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
The result is that an empty string stored as a Vary header can never be retrieved, and given no Vary header coming back from the backend, the resource is then interpreted as having no cache, even when a cache is in fact stored in Redis at the proper location.
The empty-string has special meaning for request-http-cache - that there were no Vary headers when the resource was originally cached. Unfortunately that means that any resources not serving a Vary header can never be successfully retrieved from cache.
The text was updated successfully, but these errors were encountered:
cefn
added a commit
to cefn/request-http-cache
that referenced
this issue
Nov 12, 2018
There's an issue with the ordering and truthy logic of
!buffer
at https://github.com/gitterHQ/request-http-cache/blob/master/lib/redis-backend.js#L19 in the Redis backend.The result is that an empty string stored as a Vary header can never be retrieved, and given no Vary header coming back from the backend, the resource is then interpreted as having no cache, even when a cache is in fact stored in Redis at the proper location.
The empty-string has special meaning for request-http-cache - that there were no Vary headers when the resource was originally cached. Unfortunately that means that any resources not serving a Vary header can never be successfully retrieved from cache.
The text was updated successfully, but these errors were encountered: