From 6a3677b2311f3a280b2d7f2049788066efed359e Mon Sep 17 00:00:00 2001 From: Hakan Uyumaz Date: Tue, 6 Dec 2022 20:12:03 +0100 Subject: [PATCH] Changes based on review comments --- es.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/es.go b/es.go index ec7db48..47aeab2 100644 --- a/es.go +++ b/es.go @@ -775,17 +775,14 @@ func (c *Client) DeleteIndex(indexName string) error { // Use case: You want to remove an index and all of its data. You also want to // specify query parameters such as timeout. func (c *Client) DeleteIndexWithQueryParameters(indexName string, queryParamMap map[string][]string) error { - queryParams := make([]string, len(queryParamMap)) + queryParams := make([]string, 0, len(queryParamMap)) for key, value := range queryParamMap { queryParams = append(queryParams, fmt.Sprintf("%s=%s", key, strings.Join(value, ","))) } queryString := strings.Join(queryParams, "&") - var urlBuilder strings.Builder - urlBuilder.WriteString(fmt.Sprintf("%s?%s", indexName, queryString)) - - agent := c.buildDeleteRequest(urlBuilder.String()) + agent := c.buildDeleteRequest(fmt.Sprintf("%s?%s", indexName, queryString)) var response acknowledgedResponse err := handleErrWithStruct(agent, &response)