Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensed crashing evaluating NPM sources #448

Closed
jonabc opened this issue Feb 3, 2022 · 3 comments · Fixed by #450
Closed

Licensed crashing evaluating NPM sources #448

jonabc opened this issue Feb 3, 2022 · 3 comments · Fixed by #450

Comments

@jonabc
Copy link
Contributor

jonabc commented Feb 3, 2022

From #411 (comment)

img

Looks like parent can be a String sometimes... Weird.

@villelahdenvuo FYI I'm opening a new issue on this so I can track it towards a fix.

You mentioned you can't provide a repro since it's coming from a private repo. I don't need the full repo to reproduce the issue, only the package.json/package-lock.json files. Would it be possible to share those if they don't contain sensitive/private/proprietary information? Or is there a minimal set of npm packages you're seeing the issue with that doesn't include anything private?

I can "fix" the crash, but without knowing how or why the value is a string I'm concerned about any fix introducing a new bug.

@villelahdenvuo
Copy link
Contributor

Actually it seems like a problem with NestJS dependency. Using 3.3.0 I'm getting this error:

    * mygrano-service.npm.@nestjs/microservices
      - dependency path not found

    * mygrano-service.npm.@nestjs/websockets
      - dependency path not found

And those are optional peer dependencies of @nestjs/core.

@jonabc
Copy link
Contributor Author

jonabc commented Feb 7, 2022

I'm fixing this in #450. A peerDependencies property unexpectedly had a string value, where licensed was expecting a hash.

@jonabc
Copy link
Contributor Author

jonabc commented Feb 8, 2022

the fix for this is included in release 3.4.4. Thanks again for the report and helping track down the cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants