New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double utf8 encoding #512

Closed

PascalPixel opened this issue Jun 20, 2018 · 1 comment

PascalPixel commented Jun 20, 2018 •

edited

Loading

Using this library, pushing out a string as content for createBlob encodes it to utf-8.
The result on GitHub is utf-8, so I assumed that:

either my string was already encoded (it is not, running Utf8.decode() errors)
something is encoding the string twice in the library (I can't see that anywhere)
I'm encoding the string myself already (No, and doing so on purpose results in a double-encoded utf8 string on GitHub)
GitHub's REST end point changed and accepts utf-8 by default or encodes it itself now

Either way, forking the library and removing the Encoding fixes it for me... Why is this? How does this work? 😄

Author

PascalPixel commented Jun 23, 2018

Duplicate of #463

PascalPixel closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment