Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file to an empty commit makes commit disappear #5877

Open
noamloewenstern opened this issue Dec 31, 2024 · 2 comments
Open

Move file to an empty commit makes commit disappear #5877

noamloewenstern opened this issue Dec 31, 2024 · 2 comments
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions

Comments

@noamloewenstern
Copy link

Version

0.14.4

Operating System

macOS

Distribution Method

dmg (Apple Silicon)

Describe the issue

  1. Create an empty commit "above"
  2. Moved a file within a commit, to the "above" empty commit
  3. The empty commit disappears
    The file wasn't moved or changed
Screen.Recording.2024-12-31.at.10.33.47.mov

How to reproduce

Not sure, I guess the attached video is sufficient to understand the problem

Expected behavior

Create an empty commit, moving a file into it, and see the file inside the empty commit.

Relevant log output

No response

@noamloewenstern noamloewenstern added the bug Something isn't working label Dec 31, 2024
@Caleb-T-Owens
Copy link
Contributor

Hi! Thanks for reporting! Amending commits is something that contains some known issues. I'll add this to TODO list as in the next couple weeks I might be taking a look in that area, unless of course anyone else wants to take a peek first.

@Byron Byron added the 🎉reproduced🎉 The issue could be reproduced by following the instructions label Jan 1, 2025
@Byron
Copy link
Collaborator

Byron commented Jan 1, 2025

Thanks everyone! I may add that the issue is easily reproducible, and that there doesn't seem to be anything resembling an error in the console or the application log.

INFO     move_commit_file [ 20.3ms | 40.47% / 100.00% ] project_id: 6312ee24-a44e-4d31-be16-07ac9301bebf | branch_id: b2f05e87-dae0-4e85-8a3e-faaef03cadae | from_commit_oid: "47adf2be1eaf225bc6243c0d2d5c983c0d3fd377" | to_commit_oid: "04195e607d76a02462aa260ccefe96df64e3a715" | ownership: BranchOwnershipClaims { claims: [OwnershipClaim { file_path: "newfile", hunks: [Hunk { hash: None, start: 0, end: 0 }] }] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions
Projects
None yet
Development

No branches or pull requests

3 participants