Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify doc images #48

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Modify doc images #48

merged 8 commits into from
Nov 26, 2024

Conversation

PavelLaptev
Copy link
Contributor

@PavelLaptev PavelLaptev commented Nov 26, 2024 •
edited
Loading

☕️ Reasoning

  • Updated branch stacking images.
  • Modified images so they no longer require explicit width or height props. This change was necessary because most images had incorrect width and height values. It doesn’t make sense to preserve incorrect proportions if an image fails to load.
  • Removed unused image attributes.
  • Removed the PP Editorial font since it wasn’t suitable for H2 titles and next/previous articles

@PavelLaptev PavelLaptev requested a review from krlvi November 26, 2024 05:20
@PavelLaptev PavelLaptev requested a review from ndom91 as a code owner November 26, 2024 05:20
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 5:32am

krlvi
krlvi approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@krlvi krlvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better....

@krlvi
Copy link
Member

krlvi commented Nov 26, 2024

Thank you

@krlvi krlvi merged commit d9d19d7 into main Nov 26, 2024
3 checks passed
@krlvi krlvi deleted the modify-doc-images branch November 26, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlvi krlvi krlvi approved these changes

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PavelLaptev @krlvi