fix: services without selector return all cluster pods #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #113, services without a selector, often
externalName
services, render as being associated with all pods in the cluster. This is returned as well from requests directly to the/api/services
endpoint.The issue appears to be occurring at this point in the api call.
labelsMatchSelectors doesnt have a check for if the
selectors
parameter is empty, so it never iterates and just returnstrue
for every pod. This MR ensures comparing a selectors map against a map of labels returnsfalse
when there were no selectors specified.Closes #113