Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protofire audit sol version #185

Closed
thedavidmeister opened this issue Nov 29, 2024 · 7 comments
Closed

protofire audit sol version #185

thedavidmeister opened this issue Nov 29, 2024 · 7 comments
Assignees

Comments

@thedavidmeister
Copy link
Collaborator

The Solidity pragma version 0.8.25 is used. This version introduces the PUSH0 opcode, which may not be supported by all EVM-compatible chains. The PUSH0 opcode was introduced in Solidity version 0.8.20.

@thedavidmeister thedavidmeister self-assigned this Nov 29, 2024
@thedavidmeister
Copy link
Collaborator Author

We can use solidity version 0.8.25 and target paris which is the latest fork that does not use PUSH0 or newer opcodes

@thedavidmeister
Copy link
Collaborator Author

#186 adds paris to this repo so that all tests run against it, and any deployments from this repo will use it

@thedavidmeister
Copy link
Collaborator Author

cyclofinance/cyclo.sol#1 adds paris to cyclo repo and updates this repo as a dependency, so the cyclo deployments will use it

@BlackienBad
Copy link

Confirmed

@BlackienBad
Copy link

But is it only in cyclo? its not used in the ethgild repo?

@thedavidmeister
Copy link
Collaborator Author

@BlackienBad i added paris to the foundry toml in both repos

@BlackienBad
Copy link

perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants