Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add track addresses page into navigation #333

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Add track addresses page into navigation #333

wants to merge 35 commits into from

Conversation

ninokeldishvili
Copy link
Collaborator

Description

Fixes #332

Tasks

  • Automated tests have been written for bug fixes and new features
  • Documentation has been written for new features

@ninokeldishvili ninokeldishvili linked an issue Mar 21, 2024 that may be closed by this pull request
Track Addresses #332
Open
@ninokeldishvili
Fix token overview width problem
1e08b96
@ninokeldishvili
Addresses table with mock data
da7caaf
@ninokeldishvili
Add input, button and copy address functionality
19b64a9
@ninokeldishvili
Add remove button
a4fed12
@ninokeldishvili
Use wasm to convert addresses into binary
bdccf44
@ninokeldishvili
Update wasm for cbor encoded addresses
618b1b4
@ninokeldishvili
Commit uncommeted wasm files
d05be43
@ninokeldishvili
Some refactors
a08380f
@ninokeldishvili
Create address remove/add functions with constructed data to path to …
e900892 
…a contract
@ninokeldishvili
Import rainmetadata contract abi and get contract from it
89b5e7f
@ninokeldishvili
Import contract and define it
f1118c1
@ninokeldishvili
Merge branch 'main' into 332-track-addresses
c00ffbe
@ninokeldishvili
Get addresses from subgraph
399c8d9
@ninokeldishvili
Set manager address and sg url as env variables
24444bd
@ninokeldishvili
Filter unique addresses
4345c2b
@ninokeldishvili
Check address if already exists in data
dc99fab
@ninokeldishvili
Add transaction loader screen and some checks on add address
af64638
@ninokeldishvili
Fix remove functionality
68ccc3e
@ninokeldishvili
Filter by removed addresses
a1e535f
@ninokeldishvili
Remove todo
cd675f3
@ninokeldishvili
Better solution of remove address logic
f3fcc15
@ninokeldishvili
Contract version change updates
6b11786
@ninokeldishvili
Check manager address to show/hide 'Track Addresses page'
fe04a1f
@ninokeldishvili
Fix ipfs login page test
f05f396
@ninokeldishvili
Add wait to members test. set test network
1d5181a
@ninokeldishvili ninokeldishvili self-assigned this Oct 25, 2024
@ninokeldishvili ninokeldishvili linked an issue Oct 25, 2024 that may be closed by this pull request
Implements adding addresses from FE and update CLI to get addresses from subgraph gildlab/ethgild#147
Closed
@ninokeldishvili ninokeldishvili marked this pull request as ready for review October 28, 2024 12:56
thedavidmeister
thedavidmeister requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@thedavidmeister thedavidmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no screenshots or test deployment or anything for me to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedavidmeister thedavidmeister thedavidmeister requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ninokeldishvili ninokeldishvili

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track Addresses Implements adding addresses from FE and update CLI to get addresses from subgraph
2 participants
@ninokeldishvili @thedavidmeister