Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misnomer Cohomology-Class #149

Open
jcguu95 opened this issue Jan 4, 2025 · 0 comments
Open

Misnomer Cohomology-Class #149

jcguu95 opened this issue Jan 4, 2025 · 0 comments

Comments

@jcguu95
Copy link

jcguu95 commented Jan 4, 2025

In both the current code and the 1999 Kenzo documentation, a morphism whose target is the integer unit chain complex is called a Cohomology-Class. This is a misnomer. I suggest changing it Integer-Cochain.

example in doc

{\footnotesize\begin{verbatim}
(setf id-morphism   (build-mrph :sorc ZCC
                                :trgt ZCC
                                :degr 0
                                :intr #'identity
                                :strt :cmbn
                                :orgn '(identity morphism on ZCC) ))

[K4 Cohomology-Class (degree 0)]

code needs to be fixed

(DEFMETHOD PRINT-OBJECT ((mrph morphism) stream)
  (the morphism
       (progn
         (if (eq (first (orgn (trgt mrph))) 'z-chcm)
             (format stream "[K~D Cohomology-Class on K~D of degree ~D]"
                     (idnm mrph) (idnm (sorc mrph)) (- (degr mrph)))
             (format stream "[K~D Morphism (degree ~D): K~D -> K~D]"
                     (idnm mrph) (degr mrph)
                     (idnm (sorc mrph)) (idnm (trgt mrph))))
         mrph)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant