Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the skip_verification option. #85

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

svetlyi
Copy link
Contributor

@svetlyi svetlyi commented Aug 9, 2024

This option is intended for users who prefer to verify the JWT token elsewhere while still leveraging other features provided by the module.

All the details are provided in the comment for SkipVerification in jwt.go. In short, we verify the token after the Caddy proxy in the upstreams, but we still need the other features offered by the plugin, especially parsing and populating user metadata.

Hopefully it would be useful for other people as well.

Thanks.

This option is intended for users who prefer to verify the JWT token elsewhere while still leveraging other features provided by the module.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (5f1c2a8) to head (1f4273d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   94.83%   95.05%   +0.22%     
==========================================
  Files           2        2              
  Lines         329      344      +15     
==========================================
+ Hits          312      327      +15     
  Misses         12       12              
  Partials        5        5              
Flag Coverage Δ
unittests 95.05% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ggicci
Copy link
Owner

ggicci commented Aug 10, 2024

LGTM, thanks for the contribution :)

@ggicci ggicci merged commit e1e2a8c into ggicci:main Aug 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants