From 6ee82e9a02ea6a06911e618bf2f947b1280cd562 Mon Sep 17 00:00:00 2001 From: Daniel Szoke Date: Tue, 21 Jan 2025 16:24:33 +0100 Subject: [PATCH] ci: Pin `ubuntu-24.04` for Actions runners Several of our GitHub Actions runners are running on `ubuntu-latest`, making the actions vulnerable to breakage when a new LTS version of Ubuntu is released. Therefore, we should pin to a specific version of Ubuntu. Pinning to `ubuntu-24.04` because that is currently the latest Ubuntu version, and all of our actions appear to be working at the moment. --- .github/workflows/build.yml | 12 ++++++------ .github/workflows/ci.yml | 6 +++--- .github/workflows/codeql-analysis.yml | 2 +- .github/workflows/release.yml | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e45c3971c2..1e80321f4e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,7 +25,7 @@ jobs: container: aarch64-musl name: Linux ${{ matrix.arch }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v2 @@ -144,7 +144,7 @@ jobs: node: name: NPM Package - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [linux, macos, macos_universal, windows] steps: @@ -176,7 +176,7 @@ jobs: python-base: name: python (base) - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v3 - uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # pin@v1 @@ -197,7 +197,7 @@ jobs: python: name: python - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [linux, macos, macos_universal, windows, python-base] steps: - uses: actions/checkout@v3 @@ -223,7 +223,7 @@ jobs: npm-distributions: name: 'Build NPM distributions' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [linux, macos, macos_universal, windows] steps: - uses: actions/checkout@v3 @@ -265,7 +265,7 @@ jobs: merge: name: Create Release Artifact - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [linux, macos, macos_universal, windows, npm-distributions, node, python] steps: - uses: actions/upload-artifact/merge@v4 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c00c45680b..f6613a664c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ env: jobs: lint: name: Lint - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 @@ -34,7 +34,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-24.04, macos-latest, windows-latest] name: Test (${{ matrix.os }}) runs-on: ${{ matrix.os }} @@ -65,7 +65,7 @@ jobs: node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x] name: Test Node ${{ matrix.node-version }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 2051100fa6..a97be20a38 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -21,7 +21,7 @@ on: jobs: analyze: name: Analyze - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 strategy: fail-fast: false diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 062a82bda7..328e761916 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,7 +13,7 @@ on: required: false jobs: release: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 name: 'Release a new version' steps: - name: Get auth token