Bugfixes and improvement to search suggestions

[Flo2410]

In the time since I added the search suggestions, I found some more bugs. And also was missing a Tab Complete feature.
Since I'm not sure if it's okay to just open a PR with bug fixes, I'm writing this post.

The changes can be found here.

What I did:

• Added tab complete for search suggestions to the search box and the quick launch.
• Fixed a bug where the suggestions API would be called repeatedly without the search changing.
• Fixed a bug where the search box would open the search when loosing focus.

Probably it would have been a good idea to split the bug fixes from the tab complete...

[glime-ai[bot]]

Based on the context provided, it seems you have made some enhancements and bug fixes to the Homepage project and are considering how to proceed with contributing your changes. The appropriate steps to take would be:

1. Open a Pull Request (PR): Since you have already made changes in your fork of the repository, you should open a pull request to the original Homepage repository. Make sure to clearly describe the changes you've made, the bugs you've fixed, and the feature you've added (tab complete for search suggestions).

2. Follow the Contribution Guidelines: Ensure that your pull request adheres to the project's contribution guidelines as outlined in the CONTRIBUTING.md file. This includes making sure your code is under the GNU General Public License v3.0, and that you've followed the development guidelines and coding style of the project.

3. Separate Concerns if Necessary: If it's recommended by the project maintainers, consider separating the bug fixes from the new feature into different pull requests. This can make it easier for maintainers to review and test your changes.

4. Reference Related Issues: If there are existing issues in the repository that are related to the bugs you've fixed or the feature you've added, reference them in your pull request description.

5. Wait for Review: After submitting your pull request, wait for the project maintainers to review your changes. They may request further changes or clarifications before merging your contributions.

Remember to check the project's PR template (PULL_REQUEST_TEMPLATE.md) for any additional specific instructions or checkboxes that you need to follow or mark as completed.

Since you've already made the changes and are aware of how to open a pull request, you can proceed with creating the PR on the original Homepage repository. Make sure to provide a thorough description of your changes for the maintainers to review.

---

Thanks for posting a discussion about homepage here on GitHub. Homepage now uses a fancy new AI tool thanks to our friends at Glime, so the answer below is the AI bot's attempt to answer your question. If you feel it's sufficient you can mark the answer and close this post, otherwise feel free to leave it open of course!

Thanks for using Homepage! ❤️

This comment was generated by Glime.

[shamoon]

That sounds fine to PR, though in general Id aim to not mix enhancements and bug fixes.

[Flo2410]

Okay, I got them separated. I'll open two PRs one for the bug fixes and one for the tab complete.

[github-actions[bot]]

This discussion has been automatically closed due to inactivity. See our contributing guidelines for more details.

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.