Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub apps to create pull requests #1135

Open
markdumay opened this issue Aug 25, 2024 · 2 comments
Open

Support GitHub apps to create pull requests #1135

markdumay opened this issue Aug 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@markdumay
Copy link
Collaborator

Problem or enhancement idea

Hinode requires a personal access token (PAT) to automatically create pull requests that trigger a release. This is used by the action that updates Hugo dependencies (e.g. .github/workflows/mod-update.yml). The default GITHUB_TOKEN does not suffice, at it cannot trigger other workflows. Although the PAT approach works, it is quite tedious to maintain for a growing number of repositories. When expired, each token has to be manually recreated and stored as secret. In addition, having these tokens is a potential security risk, as abuse is difficult to detect.

Proposed solution

Following the advise from Peter Evans, a GitHub App can be created for the sole purpose of generating tokens for use with GitHub actions. These tokens can be used in place of GITHUB_TOKEN or a Personal Access Token (PAT). GitHub App generated tokens are more secure than using a PAT because GitHub App access permissions can be set with finer granularity and are scoped to only repositories where the App is installed.

Alternatives

The current approach uses personal access token (PAT) - which works - but requires more maintenance and is less secure.

@markdumay markdumay added the enhancement New feature or request label Aug 25, 2024
@vinser
Copy link
Contributor

vinser commented Aug 25, 2024

To publish my Hinode docs site on GitHub Pages I use slightly modified standard GitHub Action workflow https://github.com/vinser/flibgolite-docs/blob/master/.github/workflows/hugo.yaml

May be it will help

@d-oit
Copy link
Contributor

d-oit commented Oct 13, 2024

Found this issue by excited 😆

Do you know this?

https://docs.renovatebot.com/modules/platform/github/#running-as-a-github-app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants