login.css usage based on route

[pierrejoye]

Thank you for this plugin! great work!

While trying it together with the admin plugin, I see that login.css is added to all pages, systematically. I tracked it down to:

grav-plugin-login/login.php

Line 736 in 134b6a7

if (!$this->isAdmin() && $this->config->get('plugins.login.built_in_css')) {

Should it not be based on:
/admin and below ro

• /admin specific routes
• the different login pages only (forgot, reset, register etc)
• protected pages only

?

If the above is the desired goal, I can work on a PR. Not sure if that css is needed for anything else on every page as in my case, it is not at all, with my themes or other. But I may miss something :)

[mahagr]

The code says "not in admin and toggled on", so it is added to every page which is not in admin panel.

CSS should be probably in every page in case if you have login form in them. Or rather just turn it off and use your own CSS.

[pierrejoye]

Yeah, also I am not sure it makes sense to add it all the time but when the page is actually loaded. This is what assets functions are for, here it always adds it, no matter what :)