Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German version #5

Open
jansule opened this issue Sep 2, 2020 · 2 comments
Open

German version #5

jansule opened this issue Sep 2, 2020 · 2 comments

Comments

@jansule
Copy link
Contributor

jansule commented Sep 2, 2020

It would be nice to also offer a German version of the workshop.

We already have the text for this in our commit history. We just have to readd the text and add some handling for changing the language.
@afink70
Copy link

afink70 commented Oct 1, 2020

Hi, please tell me if I can help you.

@jansule
Copy link
Contributor Author

jansule commented Oct 5, 2020

@afink70 thanks for offering help.

We mainly have the german text in the history of this repo. You can browse the repo in the state of commit b2ac3a7 to find these.

What's currently missing is the proper logic for allowing multiple languages (switching between languages, language specific url). This might include some refactoring of the files (putting all files into a dedicated folder e.g. en/ and de/).

We are happy to receive a PR from you.

In case you are interested, please open a WIP or Draft PR, so we know that there is work in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jansule @afink70