Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom to layer is not correct for the 3D tiles resources in CSW #9585

Closed
1 task done
ElenaGallo opened this issue Oct 12, 2023 · 1 comment · Fixed by #9610 or #9649
Closed
1 task done

Zoom to layer is not correct for the 3D tiles resources in CSW #9585

ElenaGallo opened this issue Oct 12, 2023 · 1 comment · Fixed by #9610 or #9649
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C027-COMUNE_FI-2023-SUPPORT
Milestone

Comments

@ElenaGallo
Copy link
Contributor

Description

After adding 3D tile layer, from a CSW service, to a map, the "Zoom to Layer" works but does not zoom to the layer correctly.

3D.tile.on.csw.mp4

How to reproduce

  • Open this map
  • Activate the 3D mode
  • Open the catalog
  • Add 20230829_test_3dtile_01 layer

Expected Result

The "Zoom to Layer" and the layer is visible on map

Current Result

The "Zoom to Layer" works but does not zoom to the layer correct

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

Related to #9368 (comment)

@ElenaGallo ElenaGallo added this to the 2024.01.00 milestone Oct 12, 2023
@ElenaGallo ElenaGallo modified the milestones: 2024.01.00, 2023.02.01 Oct 12, 2023
@tdipisa tdipisa assigned tdipisa, MV88 and mahmoudadel54 and unassigned tdipisa and MV88 Oct 12, 2023
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 12, 2023
@tdipisa
Copy link
Member

tdipisa commented Oct 17, 2023

@mahmoudadel54 the DC output of the metadata from GeoNetwork is returning the right BBOX covering the area of Florence but MS is zooming to the wrong area.
We have to:

  1. Properly handle the BBOX in the metadata and use it (a fix seems needed for this at the moment)
  2. If it is missing or MS is not able to parse it for some reason, as a fallback we can get the extent from the 3D tile as we usually do when we add 3D Tiles to the map using the related source type

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 17, 2023
- fixing by getting layer extent from tileset json
@mahmoudadel54 mahmoudadel54 linked a pull request Oct 17, 2023 that will close this issue
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 17, 2023
description: fix test case in CSW-test
MV88 pushed a commit that referenced this issue Oct 23, 2023
@ElenaGallo ElenaGallo self-assigned this Oct 24, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 24, 2023
MV88 pushed a commit that referenced this issue Oct 24, 2023
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Oct 24, 2023
@tdipisa tdipisa added the 3D All issues related to the 3D rendering in CesiumJs label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment