two versions of groovy jars in the classpath

[landryb]

as found out by @pmauduit in georchestra/ansible#125 (comment) the geonetwork war we ship so far has two versions of groovy libs in the classpath:

-rw-r----- 1 tomcat tomcat 5443828 May  9  2023 /srv/tomcat/georchestra/webapps/geonetwork/WEB-INF/lib/groovy-2.5.5.jar
-rw-r----- 1 tomcat tomcat 7203079 May  9  2023 /srv/tomcat/georchestra/webapps/geonetwork/WEB-INF/lib/groovy-all-2.4.21.jar

this prevents GN4 to start with an ugly ton of backtraces in the logs, removing groovy-2.5.5.jar from the webapp fixes the issue.

[landryb]

with groovy 2.5.5 removed, sometimes i see this in the log:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1 (file:/srv/tomcat/georchestra/webapps/geonetwork/WEB-INF/lib/groovy-all-2.4.21.jar) to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.vmplugin.v7.Java7$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

[pmauduit]

this is due to some changes in Java 9 as far as I remember, see also:
https://issues.apache.org/jira/browse/GROOVY-8339

[landryb]

@pmauduit could we use some kind of exclude for groovy-2.5.5.jar in

geonetwork/web/pom.xml

Line 944 in 9b2e374

<packagingExcludes>

to workaround this crap ?

[landryb]

i've tried the obvious diff:

[03/01 14:50] [email protected]:/data/src/georchestra/georchestra/geonetwork $git diff web/pom.xml
diff --git a/web/pom.xml b/web/pom.xml
index 1bc6a323b7..e0c1a2534d 100644
--- a/web/pom.xml
+++ b/web/pom.xml
@@ -947,6 +947,7 @@
             WEB-INF/data/index/**,
             WEB-INF/data/data/backup/**,
             WEB-INF/data/data/resources/htmlcache/**,
+            WEB-INF/lib/groovy-2.5.5.jar,
             catalog/lib/style/bootstrap/docs/**,
             catalog/lib/style/bootstrap/fonts/**,
             catalog/lib/style/bootstrap/grunt/**,

but the jar is still packaged in the war regardless:

$unzip -l /data/src/georchestra/georchestra/geonetwork/web/target/geonetwork-generic.war|grep groovy.*jar
    20372  2023-12-29 11:01   WEB-INF/lib/camel-groovy-2.25.1.jar
  5443828  2023-12-29 11:01   WEB-INF/lib/groovy-2.5.5.jar
  7203079  2023-12-29 10:56   WEB-INF/lib/groovy-all-2.4.21.jar

[landryb]

according to https://stackoverflow.com/a/36646805 packagingExcludes doesnt apply to jars coming from dependencies.

according to mvn dependency:tree the dependency comes from camel-groovy 2.25.1:

 org.geonetwork-opensource:gn-workers:pom:4.2.2-georchestra
 +- org.apache.camel:camel-groovy:jar:2.25.1:compile
 |  \- org.codehaus.groovy:groovy:jar:2.5.5:compile

an update to 2.25.4 was attempted in geonetwork/core-geonetwork#6364 but reverted later on for causing regressions.