Various wording fixes #1080
Various wording fixes #1080
Conversation
|
Affected libs:
|
|
📷 Screenshots are here! |
LHBruneton-C2C
force-pushed
the
various-wording-fixes
branch
from
ec6bc6b to
709bb4c
Compare
There was a problem hiding this comment.
Thank you! I had a question about the rich-text eye icon, but I haven't tested the change.
I think all these changes make sense, although very soon we're going to start showing more than just datasets in the Datahub. I guess we'll need to have separate translation keys for these then..
| @@ -12,10 +12,10 @@ | |||
| <span | |||
| class="material-symbols-outlined gn-ui-icon-small" | |||
| [ngClass]="{ 'text-primary': !preview }" | |||
| >{{ preview ? 'visibility' : 'visibility_off' }}</span | |||
| >{{ preview ? 'visibility_off' : 'visibility' }}</span | |||
There was a problem hiding this comment.
is that intentional? I haven't noticed that this was inverted
There was a problem hiding this comment.
It is intentional. We kind of got used to it this way, but I felt it was wrong the first time I coded it. And now with François fresh view on it, it felt odd too.
| > | ||
| | ||
| {{ preview ? 'WYSIWYG' : 'Markdown' }} | ||
| {{ preview ? 'Edit' : 'Preview' }} |
There was a problem hiding this comment.
that looks inverted as well? I thought preview meant the text was rendered properly without being editable
There was a problem hiding this comment.
Same here, it was intentional. The button shows what you can do (action), not the current state.
| "editor.record.form.section.classification.description": "The classification has an impact on the access to the data.", | ||
| "editor.record.form.section.classification.label": "Classification", | ||
| "editor.record.form.section.classification.description": "Appropriate keywords help users find the dataset.", | ||
| "editor.record.form.section.classification.label": "Keywords", |
There was a problem hiding this comment.
This might be a little too narrow; classification can also be general themes for instance (even though we don't show it yet)
| "editor.record.undo.confirmation.cancelText": "Keep the changes", | ||
| "editor.record.undo.confirmation.confirmText": "Discard the changes", | ||
| "editor.record.undo.confirmation.message": "Are you sure you want to cancel the pending changes on this record?", | ||
| "editor.record.undo.confirmation.message": "Are you sure you want to cancel the pending changes on this dataset ?", |
There was a problem hiding this comment.
| "editor.record.undo.confirmation.message": "Are you sure you want to cancel the pending changes on this dataset ?", | |
| "editor.record.undo.confirmation.message": "Are you sure you want to cancel the pending changes on this dataset?", |
LHBruneton-C2C
force-pushed
the
various-wording-fixes
branch
from
c0e4c9c to
e4a2f4e
Compare
Description
This PR is meant to improve default translation for the editor.