Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSGCT-139: Fix dates #1075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

AlitaBernachot
Copy link
Collaborator

@AlitaBernachot AlitaBernachot commented Jan 8, 2025

Description

This PR fixes the content of the "About the data" section regarding the dates: instead of displaying the metadata dates, we now display the resource related dates (recordUpdated, resourceCreated, and resourcePublished instead of recordCreated and recordPublished).

Architectural changes

None

Screenshots

No change in the UI.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Affected libs: api-metadata-converter,
Affected apps: metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Jan 8, 2025

📷 Screenshots are here!

@AlitaBernachot AlitaBernachot force-pushed the GSGCT-139-fix-dates-resources branch from 534701a to 6910b5a Compare January 24, 2025 12:28
@AlitaBernachot AlitaBernachot force-pushed the GSGCT-139-fix-dates-resources branch from 6910b5a to 129b94e Compare January 24, 2025 13:16
@AlitaBernachot AlitaBernachot marked this pull request as ready for review January 24, 2025 13:54
@coveralls
Copy link

coveralls commented Jan 24, 2025

Coverage Status

coverage: 84.791% (+0.6%) from 84.193%
when pulling bbe5552 on GSGCT-139-fix-dates-resources
into 435a18a on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks a lot! I've added a comment regarding the GN4 formatter, could you please clarify? and then feel free to merge :)

)
return {
...output,
recordPublished: datePublished,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I guessing right that this is kept for backwards compatibility? I think there can theoretically be a publicationDate field coming from the index so I would rely on this one instead of publicationDateForResource, but maybe you had a good reason to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants