-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSGCT-139: Fix dates #1075
base: main
Are you sure you want to change the base?
GSGCT-139: Fix dates #1075
Conversation
Affected libs:
|
📷 Screenshots are here! |
534701a
to
6910b5a
Compare
6910b5a
to
129b94e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks a lot! I've added a comment regarding the GN4 formatter, could you please clarify? and then feel free to merge :)
) | ||
return { | ||
...output, | ||
recordPublished: datePublished, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I guessing right that this is kept for backwards compatibility? I think there can theoretically be a publicationDate
field coming from the index so I would rely on this one instead of publicationDateForResource
, but maybe you had a good reason to do so
Description
This PR fixes the content of the "About the data" section regarding the dates: instead of displaying the metadata dates, we now display the resource related dates (
recordUpdated
,resourceCreated
, andresourcePublished
instead ofrecordCreated
andrecordPublished
).Architectural changes
None
Screenshots
No change in the UI.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label