Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary is always updated to the latest master on deploy #141

Open
skalee opened this issue Jul 5, 2020 · 3 comments
Open

Glossary is always updated to the latest master on deploy #141

skalee opened this issue Jul 5, 2020 · 3 comments
Labels
question Further information is requested

Comments

@skalee
Copy link
Contributor

skalee commented Jul 5, 2020

Although we use Git submodules for tracking version of the glossary, both build and deploy scripts always attempt to update the glossary by executing make update-modules, which is equivalent to git submodule foreach git pull origin master.

That means that any change pushed to the master branch of https://github.com/geolexica/isotc211-glossary will go live next time site is deployed. Glossary development becomes tightly coupled with site development. This will cause problems when we decide to hold on with releasing new glossary for whatever reason (breaking changes, bugs, pending reviews, etc.). We can't even deploy a tiny bugfix without deploying glossary updates.

That wasn't a problem before. Ongoing glossary development was happening in spreadsheets. New commits in isotc211-glossary repo were occasional, they were resulting either from of spreadsheet release or parser release. Now it seems different.

So — what to do, @ronaldtse, @strogonoff?

@skalee skalee added the question Further information is requested label Jul 5, 2020
@ronaldtse
Copy link
Member

  1. The goal is to eventually allow the app to directly deploy the website.
  2. Updates to the repo will be more frequent from now on since the release mechanism is now changed from spreadsheet release to change requests via the app. We need to enable some test/gating method so that the site doesn't break even if the data breaks, and enable some tests so that the data doesn't break.

@skalee
Copy link
Contributor Author

skalee commented Jul 5, 2020

Perhaps we should deploy the latest release rather than current master?

@ronaldtse
Copy link
Member

Maybe, we could bind the release to the latest approved change request? Thoughts @strogonoff ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants