Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to PRO entities #81

Open
ValWood opened this issue Apr 23, 2024 · 11 comments
Open

Links to PRO entities #81

ValWood opened this issue Apr 23, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@ValWood
Copy link

ValWood commented Apr 23, 2024

Links go to
https://proconsortium.org/cgi-bin/pro/entry_pro?id=PR:000050512

should go to
https://proconsortium.org/cgi-bin/entry_pro?id=PR_000050512

@pgaudet
Copy link

pgaudet commented Apr 23, 2024

Weird we should be using PURLs - this is what's in the dbxref file:
entity_types:
- type_name: protein
type_id: PR:000000001
id_syntax: ([OPQ][0-9][A-Z0-9]{3}[0-9]|[A-NR-Z]0-9{1,2}){1}(-[0-9]+){0,1}|[0-9]{9}
url_syntax: https://purl.obolibrary.org/obo/PR_[example_id]
example_id: PR:Q64445
example_url: https://purl.obolibrary.org/obo/PR_000060258

@kltm is this what is implemented? Are the PURLs not resolved correctly? (this make it a PRO issue, not GO).

@kltm
Copy link
Member

kltm commented Apr 23, 2024

It would be good to see the links in context--I'm not sure where this is occurring.
Usually, this kind of thing would be driven by the dbxrefs.yaml in go-site, but there may be an issue in information propagation or hard-coding.

@ValWood
Copy link
Author

ValWood commented Apr 23, 2024

The xref file specifies PR_000060258
Noctua is using PR:000060258

@kltm
Copy link
Member

kltm commented Apr 23, 2024

@ValWood Can you give a link to where in Noctua you are seeing this?

@ValWood
Copy link
Author

ValWood commented Apr 23, 2024

In my model
meiotic cohesion protection at anaphase I
Double-click on entity rec8. You will see the PR identifier under rec8 Spom in the right hand panel

@kltm
Copy link
Member

kltm commented Apr 23, 2024

@kltm
Copy link
Member

kltm commented Apr 23, 2024

Going to https://amigo.geneontology.org/amigo/gene_product/PomBase:SPBC29A10.14 , then adding direct term filter "topological DNA co-entrapment activity", we get an annotation with isoform PR:000050512, that links to https://purl.obolibrary.org/obo/PR_000050512 . This would seem to indicate that the metadata, at least some places, is healthy.

@kltm
Copy link
Member

kltm commented Apr 23, 2024

Noting that "noctua-visual-pathway-editor/src/@noctua.curie/data/go-context.ts" seems correct.
My next best guess would be package.json in noctua-visual-pathway-editor:

    "amigo2": "^2.4.3"

...unfortunately, I'm having trouble building the local packages for the moment (I may need to ask @pkalita-lbl for help here). It may be worthwhile first to clarify with @tmushayahama where this metadata is coming from: an npm package, go-site, or the contexts file?

kltm referenced this issue in geneontology/amigo Apr 25, 2024
Add draft documentation for how to do npm package releases from the docker images; for https://github.com/geneontology/noctua/issues/879 .
Thanks to @pkalita-lbl
@kltm
Copy link
Member

kltm commented Apr 29, 2024

I think we need @tmushayahama 's input here before acting. @tmushayahama , can you pinpoint where that information is coming from, in case packages need a refresh or if it's wired in some other way?

@vanaukenk vanaukenk transferred this issue from geneontology/noctua May 30, 2024
@vanaukenk
Copy link

Noting that the incorrect link is also happening for PRO entries on the Noctua form editor.

@vanaukenk vanaukenk added the bug Something isn't working label May 30, 2024
@pgaudet
Copy link

pgaudet commented Jul 15, 2024

ping @tmushayahama , can you pinpoint where that information is coming from, in case packages need a refresh or if it's wired in some other way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

5 participants