Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all information in Activity units #58

Open
pgaudet opened this issue Mar 2, 2023 · 6 comments
Open

Display all information in Activity units #58

pgaudet opened this issue Mar 2, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@pgaudet
Copy link

pgaudet commented Mar 2, 2023

Hello,

After a few months of using the visual editor, we'd like to have all data shown in activity units in the curation interface, otherwise it's too confusing for curators (ie, default view should be 'detailed) .

Also, the size limit on GO terms should be removed.

Thanks, Pascale

@tmushayahama
Copy link
Collaborator

tmushayahama commented Jun 22, 2023

Will be working on this one. It will be a quick one. Few clarifications

  • On layout view dropdown, what text should I put instead of Default View, Detailed View, preview?
  • Default View will be the detailed view?
  • What is the size limit, you mean the truncated term if it is long? I am worried some go terms are too large. Can we increase to like 50 characters or 3 lines?

Things to note

  • it will be a bit slower on initial loading and moving around for really large models
  • some models have complexes with lots of has_parts or Reactome like with many has_output has_input (I haven't put a limit so far). Lemme know if any big model will give problems
  • not many activities will be displayed on one viewport (one page before scrolling)
  • Connecting far away activities

Tagging @pgaudet @vanaukenk

@pgaudet
Copy link
Author

pgaudet commented Jun 22, 2023

On layout view dropdown, what text should I put instead of Default View, Detailed View, preview?

How about 'Simple view'?
(@pmasson55 's suggestion)

Default View will be the detailed view?

Yes

What is the size limit, you mean the truncated term if it is long? I am worried some go terms are too large. Can we increase to like 50 characters or 3 lines?

What is the current limit?

Thanks, Pascale

@pgaudet
Copy link
Author

pgaudet commented Jul 26, 2023

Hi @tmushayahama

Can this work be scheduled ? This is the one feature that makes the visual editor difficult to use - we dont see all the information in the model, we always have to switch to the default view.

Thanks, Pascale

@vanaukenk
Copy link

@pgaudet @tmushayahama

Just checking after today's maintenance outage that the display issue with GO term labels is satisfactory. Some still seem to be getting truncated.

@tmushayahama
Copy link
Collaborator

@vanaukenk @pgaudet I think this now is the default view.

@pgaudet
Copy link
Author

pgaudet commented Feb 6, 2024

Hi @tmushayahama

Noting that the Default view and the Simple View now display the same information.

This is OK for the Swiss-Prot curators; but for clarity, could you remove the Simple View option ? (middle one in the screenshot below):

image

Thanks, Pascale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants