-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecoli data is gone from NEO as the upstream source changed #114
Comments
Okay, I think that this may be cleared naturally as the datasets.json does seem to refresh to the correct value. |
Check next week on a test server. |
Data does seem to be in there now, although we may want to do more tweaks. |
I think "intended" here is not quite right. Maybe. Initially, I thought this might be due to the ongoing deal with geneontology/go-site#1961, but it seems to stem from (by several steps) from https://github.com/geneontology/go-site/blob/8b649d799b522af9ca28f560f71ec1c978076d99/metadata/datasets/ecocyc.yaml#L22 being null. And it has been like that for years, so I'm not sure if this was intentional for some reason or not? Easy enough to fix it that was an oversight somewhere along the way. That said, this is apparently the way it was before the churn for geneontology/go-site#1961 started, so at least that much is correct. |
FWIW geneontology/go-site#1994 added |
Recheck today after outage |
Ugh, issue is persisting. |
Okay, @pgaudet , I think I've tracked this back to an assumption in the "NEO Makefile builder" that believes that everything is compressed, which is not true for the ecoli/ecocyc data.
|
Testing; build in pipeline. @pgaudet @vanaukenk If this works (and I believe it will), we probably want to get this out before the next outage in a month. |
@pgaudet @vanaukenk I believe this is (finally) working now. |
Maybe there are multiple problems - in this model http://noctua.geneontology.org/workbench/noctua-visual-pathway-editor/?model_id=gomodel:62f58d8800001680 Thanks, Pascale |
@pgaudet I think that that is a different issue: we can confirm that Ecoli data is now present in NEO. As this fix went in after the outage, it may be related to that, or another issue. That said, it appears in autocomplete dropdowns now, so the data is there (which is the scope of this ticket). Also note: #111 |
In exploring the NEO load, we discovered that there are no ecoli entries, likely due to the upstream file change.
To close this, update to the new (temp) file and reload.
The text was updated successfully, but these errors were encountered: