Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No update button in modal dialog present. #50

Open
opicron opened this issue Dec 7, 2024 · 2 comments
Open

No update button in modal dialog present. #50

opicron opened this issue Dec 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@opicron
Copy link

opicron commented Dec 7, 2024

I found that there is no Update button in the popup modal:

image

When using my Github updater it looks like this:

image

As far as I know the button is shown when the ['download_link'] field has been set in the return object of the following hook:

// get plugin details for view details page
add_filter('plugins_api', [$this, 'plugin_api'], 10, 3);

Additionally it might be nice to add the extra fields like description, version, author etc.

@gdarko
Copy link
Owner

gdarko commented Dec 7, 2024

Hey @opicron - Thanks for reporting this.

Is the "Update now" link/button present when not using the modal in the Plugins page?

Best Regards,
Darko

@opicron
Copy link
Author

opicron commented Dec 8, 2024

Yes, the update now is available in the action bar commands.

@gdarko gdarko self-assigned this Dec 13, 2024
@gdarko gdarko added the bug Something isn't working label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants