Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker hub image with latest tomcat version #1529

Open
LordFlashmeow opened this issue Jan 21, 2021 · 7 comments · May be fixed by #2635
Open

Update docker hub image with latest tomcat version #1529

LordFlashmeow opened this issue Jan 21, 2021 · 7 comments · May be fixed by #2635
Assignees
Milestone

Comments

@LordFlashmeow
Copy link

The tomcat:8.5-jdk8 base image has been updated since the last ipt image was published to docker hub. There is a (minor) security vulnerability in tomcat 8.5.57, which is the version in the ipt image.

The latest version is 8.5.61, and it would be very much appreciated if you could publish a docker image with the latest tomcat base.

@MattBlissett
Copy link
Member

Thanks for the alert, I've published an updated image. Do you know a way to get notified when Tomcat update their images?

(We aren't using Docker images like this in production at GBIF.)

@LordFlashmeow
Copy link
Author

There used to be a setting in docker hub automated builds where you could link to another image, and updates to it would trigger a rebuild. Unfortunately, it looks like it was removed (docker/hub-feedback#1717).

@MattBlissett MattBlissett self-assigned this Apr 28, 2021
@MattBlissett MattBlissett added this to the 2.5 milestone Apr 28, 2021
@mike-podolskiy90 mike-podolskiy90 modified the milestones: 2.x, 3.x Nov 7, 2024
@krkabol
Copy link

krkabol commented Jan 8, 2025

Hi,
I propose to look at GitHub actions&Dependabot. As an example, let me provide this repository , the main idea is:

  1. refer to the base image with tag including SHA https://github.com/krkabol/php-fpm-noroot-socket/blob/main/Dockerfile
  2. setup Dependabot to regulary check updates of base image https://github.com/krkabol/php-fpm-noroot-socket/blob/main/.github/dependabot.yml. When new image is published, a Merge request is created.
  3. and ideally stop publishing images manually and use GA to build&publish - https://github.com/krkabol/php-fpm-noroot-socket/blob/main/.github/workflows/publish.yml (publishing the image in GitHub registry, able to DockerHub also)

I can prepare pull request when interested

best
Petr

@mike-podolskiy90
Copy link
Contributor

Thank you @krkabol

Yes please, feel free to submit a PR.

@mike-podolskiy90 mike-podolskiy90 modified the milestones: 3.x, 3.2 Jan 8, 2025
@MattBlissett
Copy link
Member

Note images aren't published manually, they are built by GBIF's Jenkins server: https://builds.gbif.org/job/ipt/

If you change that to use Github Actions, we'll need to work out the necessary authentication to update the images on docker.gbif.org, as well as hub.docker.com.

@krkabol
Copy link

krkabol commented Jan 9, 2025

sorry, I've mixed two topics - point 1+2 target the "automated base image update checks" of this issue and I will focus on it in PR. For point 3 @MattBlissett:

You are right, I see now the build is done by Jenkins, not sure about publishing as two dependent but different stages. According to this note in the repository I got an impression that publishing to registries is not automated, which is what GA can combine very well (automated build + automated push). Compared to hook or trigger after push to the repository, GAs bring less complexity and more clarity and above all preserve the integrity of the code and its processing. If a change in code (or branch logic etc) requires a change in CI, these changes are bundled in one commit which is very advantageous compared to a detached Jenkins solution.

So much of my mental digression - I don't want to change your established practices by leaps and bounds, I'm just sharing my current positive experience where GA has dramatically transformed the availability of quality CI. Authentication to any registry is simple, just providing credentials as secrets.
best
P

@krkabol
Copy link

krkabol commented Jan 9, 2025

Please see https://docs.renovatebot.com/docker/ - Dependabot and Renovate bot are doing the same job. The core solution is to include sha digest to the FROM cmd, using whichever bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants