-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action throws error after Update #210
Comments
@kristofzerbe you were using Custom tags are supposed to work with:
name: Latest blog post workflow
on:
schedule: # Run workflow automatically
- cron: '0 * * * *' # Runs every hour, on the hour
workflow_dispatch: # Run workflow manually (without waiting for the cron to be called), through the Github Actions Workflow page directly
jobs:
update-readme-with-blog:
name: Update this repo's README with latest blog posts
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: gautamkrishnar/blog-post-workflow@master
with:
feed_list: "https://example.com/feeds"
custom_tags: "channelId/yt:channelId/,videoId/yt:videoId/"
template: [$title]($url) $channelId $videoId You are trying access:
Which is not supported by customTags. It doesn't support this tag with an attribute. it only suports:
|
@kristofzerbe Looks like this is achievable via the current version of the feed parser. Will try to implement this feature when I have time. I recently upgraded the feed parser library. It is breaking due to that. Since this is an uncommon use case, most people won't see any issues using the workflow. |
@kristofzerbe if possible can you please rebase the PR you opened here rbren/rss-parser#224 it would easier if we have the code in the rss feed parser upstream instead of this project. |
Closing this since this is not a common use case. Will take a look at this once rbren/rss-parser#224 is merged |
Describe the bug
With the new version 5 days ago, my action using blog-postworkflow throws the error
Error: TypeError: Cannot convert object to primitive value
.Expected behavior
Run without error
Workflow Yml Used
Additional context
My config doesn't changed
The text was updated successfully, but these errors were encountered: