Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Windows/UNIX line endings in GAP Windows distribution #111

Open
olexandr-konovalov opened this issue Apr 5, 2020 · 2 comments
Open

Windows/UNIX line endings in GAP Windows distribution #111

olexandr-konovalov opened this issue Apr 5, 2020 · 2 comments

Comments

@olexandr-konovalov
Copy link
Member

olexandr-konovalov commented Apr 5, 2020

We are classifying files into text and binary, and ensure that in the -win.zip archive, text files have Windows line endings. This is ensured in https://github.com/gap-system/gap-distribution/tree/master/DistributionUpdate with classify* and patterns* files.

The question is whether do we want this to be used in the future? In the past, this helped when users opened GAP library files in the Windows notepad and were able to see it properly, and not garbled. Today however, there are many more advanced Windows editors which handle Unix line endings properly, e.g. free Notepad++. So one could argue that this step is no longer necessary.

On the other hand, there may be always beginner users not knowing which editor to use, and GAP package authors developing under Windows. For the former, we can make the advice about an editor more prominent. For the latter, calling git config --global core.autocrlf true once sets proper line endings handling on Windows.

What do you think?

@fingolfin
Copy link
Member

fingolfin commented Apr 5, 2020

I see no point in those archives. Beginners will use the exe installer anyway. If people think that one should install files with CRLF line ends, I am fine with it. But source archives are for expert users anyway.

Should the files installed by the .exe installer on Windows then use CRLF? I am neutral in this; would be interesting if people who actually use Windows commented

@olexandr-konovalov
Copy link
Member Author

@fingolfin Just to clarify, .exe installer is currently made from -win.zip archive, so those using it are still getting CRLF endings anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants