Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELBDM improvement list #384

Open
2 of 13 tasks
ChunYen-Chen opened this issue Dec 10, 2024 · 0 comments
Open
2 of 13 tasks

ELBDM improvement list #384

ChunYen-Chen opened this issue Dec 10, 2024 · 0 comments

Comments

@ChunYen-Chen
Copy link
Collaborator

ChunYen-Chen commented Dec 10, 2024 •
edited
Loading

TODOs in the follow-up PR:

  • Wiki of ELBDM
    • configure options
    • ELBDM scheme
    • Spectral refinement
    • New runtime parameters
      • SPEC_INT_VORTEX_THRESHOLD
      • SPEC_INT_GHOST_BOUNDARY
      • ...
  • Update all generate_make.sh according to Wiki update: gamer usage #332
  • Update Python scripts under example to be compatible with Python3 (and the latest yt)
  • Unify the code style of ELBDM code
  • Update the implementation of amr->use_wave_flag[] to improve the readability
  • Generalize the spectral refinement criterion to make it dimensionless(?)

Originally posted by @ChunYen-Chen in #376 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChunYen-Chen