Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust recursion in Group.getAllChildren() #283

Open
BenjaminDRichards opened this issue Nov 23, 2016 · 1 comment
Open

More robust recursion in Group.getAllChildren() #283

BenjaminDRichards opened this issue Nov 23, 2016 · 1 comment

Comments

@BenjaminDRichards
Copy link
Contributor

The current implementation is hard-locked to just check for Group, via objType()==="Group". This means it doesn't play well with extreme group derivatives, such as the forthcoming buffered rendering plugin. It would be better to check for children that implement getAllChildren() themselves.

@BenjaminDRichards
Copy link
Contributor Author

Addendum thought: There's a possibility of getting infinite loops if the group derivative doesn't prevent such behavior. For example, buffers can form simple feedback loops, although they cannot self-feedback in a single step. We should at least point out that getAllChildren() implementations should self-avert in some fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant