Merge back to Aura?

[pmjones]

Hey there -- do you think things are mostly ready to merge into the Aura.Http package? I think it'd be cool to have it in for beta3.

[harikt]

+1 for beta3 :-)

[galactic-void]

Cool, its mostly done It just needs some more docblocks and tests although the adapters are not tested at all.

Currently the Cookies and Headers classes in Aura\Http would be overwritten, but they should be backwards compatible with the exception of __construct.

Any suggestions / thoughts on what else needs done before merging?

[harikt]

@galactic-void one thing I suggest is to make a repository of the Aura.Http , so we all can fork and play with it , merge branches and do corrections if any etc . As currently it resides in Nursery I feel this will become hard man .

@pmjones what do you feel about this ?

I don't have any other thoughts man .. Good work , looking forward :-)

[harikt]

@galactic-void Thank you for the new fork and good work :-)

But why we are not able to create issues there ?

I have some thoughts by the way reading the docs

1 ) Can't we make a RequestFactory which do create the instance of objects like

$headers = new Http\Headers(new HeaderFactory);
$cookies = new Http\Cookies(new CookieFactory);

$response         = new Request\Response($headers, $cookies);
$response_builder = new Request\ResponseBuilder($response, new StackFactory);

$adapter = new Request\Adapter\Curl($response_builder);
$request = new Request($adapter, $headers, $cookies);

So the work of remembering all stuffs will decreases , and by default let the adapter be curl . And if they need let them pass it as an array ?

2 ) I guess you don't need to have the line use Aura\Http as Http; , for we already are including all others .

Good to move require src.php to top .

Thank you once again .

More issues / suggestions will be updated once I start playing with it :-) , if you can make the issues active I can post it there .

[galactic-void]

I like the idea of a RequestFactory I'm go to do that tonight.

I've turned issues on the forked repository.

[harikt]

@galactic-void yey :-) . Thank you .