Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Parser support for 3.0 and 3.1 #2

Closed
fgsch opened this issue Jan 13, 2018 · 6 comments
Closed

Parser support for 3.0 and 3.1 #2

fgsch opened this issue Jan 13, 2018 · 6 comments

Comments

@fgsch
Copy link
Contributor

fgsch commented Jan 13, 2018

I've opened #1 to fix some issues with v3.1/dev.

Should I add support for v3.0/dev as well?
Do we want to support both versions in a single metamodel?

Let me know what your thoughts are and I can modify it to handle both.

@fzipi
Copy link
Owner

fzipi commented Jan 31, 2018

Hi @fgsch, thanks for patch #1!

Do you think it is relevant to add support for v3.0/dev? It it is for you, just do it.

I will begin working on using the parser for converting rules to the 'CRS format' of the new 3.1/dev. I've got a lot of rules written that will benefit from this.

@fgsch
Copy link
Contributor Author

fgsch commented Feb 6, 2018

While I'm still using 3.0 I think we should focus on 3.1, so either have different metamodels for each version, or drop 3.0 entirely.

That said, in order to parse the Trustwave ruleset more work is needed (I have part of this done already) and I think they are closer to 3.0 than 3.1.

So perhaps the best course of action is to have a single metamodel that supports everything and once that's done figure the next steps. This might make more sense in context of #4 as well.

@fzipi
Copy link
Owner

fzipi commented Feb 7, 2018

I agree. Sadly, as I don't have the Trustvawe ruleset here, I would delegate that task on you. When/If I put my hands on it, I can help you with that.

@fgsch fgsch mentioned this issue Feb 19, 2018
@fgsch
Copy link
Contributor Author

fgsch commented Feb 20, 2018

I have one outstanding change to fix parsing in v3.1/dev (related to SpiderLabs/owasp-modsecurity-crs#1017).

I will try to open it this week before moving to Trustwave.

@fgsch
Copy link
Contributor Author

fgsch commented Jul 13, 2018

Remaining work for v3.1/dev support at #6.

@fgsch
Copy link
Contributor Author

fgsch commented Jul 16, 2018

This should be completed now.

@fgsch fgsch closed this as completed Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants