Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support July 2024 version of Temporal API #47

Open
rauschma opened this issue Sep 6, 2024 · 7 comments
Open

Support July 2024 version of Temporal API #47

rauschma opened this issue Sep 6, 2024 · 7 comments

Comments

@rauschma
Copy link

rauschma commented Sep 6, 2024

(As an aside: The comparison table in the readme is very helpful, especially the dates/versions of the supported APIs. 🙏)

@arshaw
Copy link
Member

arshaw commented Sep 6, 2024

Definitely. I hope to get this done this month.

@rauschma
Copy link
Author

rauschma commented Sep 6, 2024

Excellent! I’m really looking forward to using the final Temporal API in my projects.

@arshaw
Copy link
Member

arshaw commented Oct 2, 2024

Correction: it will be sometime this quarter. Apologies for the delay.

@o-t-w
Copy link

o-t-w commented Jan 10, 2025

Is anybody working on this?
Is there a simple list of everything that needs to be removed?

I'd be happy to do a PR for
some of the changes.

@rauschma
Copy link
Author

FWIW – these are two links I’ve had on my “read in the future” list for a while; maybe they are useful:

@fabon-f
Copy link

fabon-f commented Jan 10, 2025

Also we have to update the forked version of test262 under fullcalendar org (https://github.com/fullcalendar/test262 ), but there are several choices how to update it: merge upstream little by little, or bigbang pull request all at once? There are several changes only in forked version and perhaps merging isn't obvious.

I'm concerned that practically only core maintainers who know the context well can make this change (coming pull requests for forked test262 can be hard to review for maintainers in terms of both quality and quantity).

@arshaw
Copy link
Member

arshaw commented Jan 10, 2025

Hello everyone, apologies for delay in in updating to the latest spec, I've been swamped with the latest major release of FullCalendar (which pays the bills). I am still very excited to implement the reduced-scope Temporal spec, especially because it will result in a smaller polyfill (potentially going from 20kb -> 17kb, but who knows).

I don't have a definitive list of things that changed since the last spec update (temporal-polyfill uses Apr 2024), but honestly it doesn't really matter because I plan to rip out the obvious things like Calendar and TimeZone classes, any logic that accepts/emits them, add ZonedDateTime::getTimeZoneTransition, then run test262 and let the failures guide me. The failures will jog my memory from past discussions in Temporal champions meetings.

As far as test262, the fullcalendar fork changed to correct diffing/rounding bugs in the spec, which are now fixed, and relaxed conformance for Calendar/TimeZone, which have now been removed. So, in theory, this polyfill should have perfect compliance with the unaltered test262 suite. That's where I plan to start: with the latest tc39/test262.

Unfortunately, I won't have bandwidth to resume this work until FullCalendar v7 launches, which is slated for Feb 14th. It might be possible for someone to aid in the meantime, but honestly running the test262 suite will be overwhelming for most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants