You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a strange thing in list of elements, namely all of them are called "Input", but actually almost half of them are not. (I am referring to an element rendering into an input tag or not)
So I propose the following change: Rename the Input directory to Element and create an Input dir under it and move all real Input elements under it (with the necessary namespace changes of course).
Also, the inheritance should also respect this structure, eg. InputElement should only be used for real input elements.
The text was updated successfully, but these errors were encountered:
Not really at the moment. My general thinking was just clearing up some of the duplicated code within the element classes/parent classes and getting the test coverage up.
There is a strange thing in list of elements, namely all of them are called "Input", but actually almost half of them are not. (I am referring to an element rendering into an input tag or not)
So I propose the following change: Rename the Input directory to Element and create an Input dir under it and move all real Input elements under it (with the necessary namespace changes of course).
Also, the inheritance should also respect this structure, eg. InputElement should only be used for real input elements.
The text was updated successfully, but these errors were encountered: