Opt-in to use included prettier version #248
Comments
|
I think that's a fair ask. Would you be ok with it being opt-out? I'm a bit worried with changing the default behavior and breaking other people's workflow. |
|
Yeah. While not optimal I understand the wish of not breaking an already established default. Give me a ping if you need help with the implementation! |
|
This is also a great feature in situations where the bundled prettier version is fine for some file types. I would want to use the bundled version for json or markdown but not JavaScript and Typescript. |
|
@sQVe yeah just wondering what's the best way to configure prettierd. We can keep adding environment variables, but I imagine that at some point we'll want to introduce a config file in some location ($XDG_CONFIG_HOME or something like that). Not sure if you have any opinions on that. |
|
I would actually prefer to configure it via the CLI. But then again I'm not interested in providing a global prettier config - I would fallback to the default in those cases. I would say that we optimally should create a prettierd dot file. Options via CLI overrides already set options. That would probably cover all use-cases. |
The idea is that when PRETTIERD_DISABLE_BUNDLED_PRETTIER is set and prettier isn't installed locally, we want to skip formatting and just return the file as is. Closes #248.
The idea is that when PRETTIERD_DISABLE_BUNDLED_PRETTIER is set and prettier isn't installed locally, we want to skip formatting and just return the file as is. Closes #248.
The idea is that when PRETTIERD_DISABLE_BUNDLED_PRETTIER is set and prettier isn't installed locally, we want to skip formatting and just return the file as is. Closes #248.
|
Closing this as #250 is a great first solution for this problem. |
The idea is that when PRETTIERD_DISABLE_BUNDLED_PRETTIER is set and prettier isn't installed locally, we want to skip formatting and just return the file as is. Closes #248.
Hey 👋🏼,
If
prettierddoesn't find a local version is falls back to the included version in this package. This is an issue in cases where a project doesn't runprettierand you introduce a lot of changes, which mainly is due to formatting.I would argue that this is unwanted behavior and should not be the default but rather an opt-in option. What are your thoughts?
This is the only reason I'm currently using
prettier_d_sliminstead of this project, but since my PR (mikew/prettier_d_slim#11) never get merged I'd like to move over to this project and help out when I can.The text was updated successfully, but these errors were encountered: