Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRO Add ascension+bonusAbility+statBoost checks for statBoosts in char util #2568

Open
nguyentvan7 opened this issue Dec 7, 2024 · 3 comments
Labels
SRO For Star Rail Optimizer

Comments

@nguyentvan7
Copy link
Collaborator

Looks like this is path-dependent

AvatarSkillTreeConfig -> PrePoint, AvatarLevelLimit, AvatarPromotionLimit

@nguyentvan7 nguyentvan7 converted this from a draft issue Dec 7, 2024
@nguyentvan7 nguyentvan7 added the SRO For Star Rail Optimizer label Dec 7, 2024
@frzyc
Copy link
Owner

frzyc commented Dec 7, 2024

I would say this should be low priority, especially for MVP, unless you think you can do it relatively quickly (say less than 2 hours)

@nguyentvan7
Copy link
Collaborator Author

Hm? you already did like 80% of the work in #2562, thats why I converted it from draft to real issue

@frzyc
Copy link
Owner

frzyc commented Dec 7, 2024

Fair, I did the PR without touching any of the datamine, so I drew the line there.

@frzyc frzyc changed the title Add ascension+bonusAbility+statBoost checks for statBoosts in char util SRO Add ascension+bonusAbility+statBoost checks for statBoosts in char util Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
Status: Ready
Development

No branches or pull requests

2 participants